Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppdli-0000rr-5T for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Apr 2023 23:32:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ppdlh-0000vv-4g for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Apr 2023 23:32:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppdlg-0000vm-RX for pgsql-hackers@lists.postgresql.org; Thu, 20 Apr 2023 23:32:48 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1ppdle-000xgI-Dr for pgsql-hackers@lists.postgresql.org; Thu, 20 Apr 2023 23:32:47 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1a6670671e3so15592935ad.0 for ; Thu, 20 Apr 2023 16:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682033565; x=1684625565; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hz87yVXWzidhUkelY6t6bsMRhac4PQuf+qAaEaJAs4w=; b=fO7r1uFyfmaKJRxwCv3S3L2q5r5FOFszVEC1KVlK61vCEZgeBq99gx2VStdYccvXW7 VcGLdMBq2I2S1ZXEktjOqLTMStulJCHYnzTyqj8asH/ViYE6SWTaVIoVuLzJDjKt2vih t6g/mmGfjT9Nx/NCsIxPRHSEDNo+RZ3gBYQu0Nqx8j36U0hWeneIXhWN98/COo2MnwYP dIndZokPlMtJsgwUegltQtUo7XjE1nb2bw0sIpCArlT5Uk9LW7nSwz5IcSTy435BsvcJ QmEULM0n8uRp4atSeOd+sw0NGGtj1meM552UR/KTxi9GfrsWFh2CPTIpB8E/QcCdpmQi K0Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682033565; x=1684625565; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hz87yVXWzidhUkelY6t6bsMRhac4PQuf+qAaEaJAs4w=; b=aCkWmSMK2XNFmsQ0WvxzR97GDjhgM/wYJRzX76WrLQN9e68EjkxAsXeXH7JQMAf08o t6QIwbkvL7uU0O9OEEeH3GV5K8GS08dzbzcyY+e/Fz6Nc6LUg85yI5qE7BNDB9NgCNPP E69/Wn1WTQ1wQvXx87ITRjzeNCnxqu2T4NRm3f0x0wyAIbP0GzIDy7TcSosLNvoSlDLV WeLSvP41lCVyZ3jBfWHN2IeMrCyS/qIuhTlLNiPfZWDPZvF+6k+YeXUcce4E2fuK2mRJ gbE0F9KdhN2vXacmq1zBXEXqFv43kekKq5J1Hvw9XEKBg2SYsxlTVmh/iilkAxeZDn+w HR8g== X-Gm-Message-State: AAQBX9e69uJOgYc3yu3o85sKgKLf1RvixEqmgqf7jWN2qzDBCRs+n4Nn +rhZH3e2YUqFmTctNClqYT+vdRM8vUw= X-Google-Smtp-Source: AKy350aV1vSw3Y94VJAJOCM0BtxVCuqxIW2Gad9aeojyT25Sn/VncAI14oeBzC6t+/YPtkeVuItY4Q== X-Received: by 2002:a17:902:ab58:b0:1a2:87a2:c910 with SMTP id ij24-20020a170902ab5800b001a287a2c910mr2767345plb.53.1682033565428; Thu, 20 Apr 2023 16:32:45 -0700 (PDT) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id p8-20020a1709026b8800b001a04ff0e2eesm1632818plk.58.2023.04.20.16.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 16:32:45 -0700 (PDT) Date: Thu, 20 Apr 2023 16:32:43 -0700 From: Nathan Bossart To: Daniel Gustafsson Cc: Yurii Rashkovskii , pgsql-hackers@lists.postgresql.org Subject: Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name Message-ID: <20230420233243.GB1437940@nathanxps13> References: <20230313173528.GA195204@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Mar 15, 2023 at 10:38:34AM +0100, Daniel Gustafsson wrote: > While here, I wonder if we should document what BGW_MAXLEN is defined as in > bgworker.sgml? I am -0.5 for this. If you are writing a new background worker, it's probably reasonable to expect that you can locate the definition of BGW_MAXLEN. Also, I think there's a good chance that we'd forget to update such documentation the next time we adjust it. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com