public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: Yurii Rashkovskii <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
Date: Fri, 21 Apr 2023 13:44:51 -0700
Message-ID: <20230421204451.GC1440148@nathanxps13> (raw)
In-Reply-To: <[email protected]>
References: <CA+RLCQyjFV5Y8tG5QgUb6gjteL4S3p+1gcyqWTqigyM93WZ9Pg@mail.gmail.com>
	<20230313173528.GA195204@nathanxps13>
	<[email protected]>
	<20230420233243.GB1437940@nathanxps13>
	<[email protected]>

On Fri, Apr 21, 2023 at 10:49:48AM +0200, Daniel Gustafsson wrote:
> On 21 Apr 2023, at 01:32, Nathan Bossart <[email protected]> wrote:
>> I am -0.5 for this.  If you are writing a new background worker, it's
>> probably reasonable to expect that you can locate the definition of
>> BGW_MAXLEN.  
> 
> Of course.  The question is if it's a helpful addition for someone who is
> reading the documentation section on implementing background workers where we
> explicitly mention BGW_MAXLEN without saying what it is.

IMHO it's better to have folks use the macro so that their calls to
snprintf(), etc. are updated when BGW_MAXLEN is changed.  But I can't say
I'm strongly opposed to adding the value to the docs if you think it is
helpful.

>> Also, I think there's a good chance that we'd forget to update
>> such documentation the next time we adjust it.
> 
> There is that, but once set to MAXPGPATH it seems unlikely to change
> particularly often so it seems the wrong thing to optimize for.

True.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
  In-Reply-To: <20230421204451.GC1440148@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox