Date: Sat, 22 Apr 2023 13:33:25 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Andres Freund <andres@anarazel.de>,
	Bruce Momjian <bruce@momjian.us>,
	Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: run pgindent on a regular basis / scripted manner
Message-ID: <20230422203325.GC1708514@rfd.leadboat.com>
References: <Y9groc0Nyy7SOROy@momjian.us>
 <20230202062838.GA1832088@rfd.leadboat.com>
 <1477791.1675320029@sss.pgh.pa.us>
 <764a8f96-58c3-361d-428f-7ef827d62023@enterprisedb.com>
 <20230206212157.axnz62oagvycvcjm@awork3.anarazel.de>
 <2828975.1675719367@sss.pgh.pa.us>
 <20230207044324.GB2017197@rfd.leadboat.com>
 <CABUevEzdOYU2WFu=Hj+F4mkZV-TxLyS1d+azo4cMB3fSN7r37w@mail.gmail.com>
 <20230422195906.GB1708514@rfd.leadboat.com>
 <3713260.1682194523@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3713260.1682194523@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20230422203325.GC1708514%40rfd.leadboat.com>
Precedence: bulk

On Sat, Apr 22, 2023 at 04:15:23PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > - skip if the break-glass "pgindent: no" appears in a commit message
> 
> There are two things that bother me about putting this functionality
> into a server hook, beyond the possible speed issue:
> 
> * The risk of failure.  I don't have a terribly difficult time imagining
> situations where things get sufficiently wedged that the server accepts
> *no* commits, not even ones fixing the problem.  An override such as
> you suggest here could assuage that fear, perhaps.

I agree that deserves some worry.

> * The lack of user-friendliness.  AFAIK, if a pre-receive hook fails
> you learn little except that it failed.

That is incorrect.  The client gets whatever the hook prints.  I'd probably
make it print the first 10000 lines of the diff.


I'm okay with a buildfarm animal.  It's going to result in a more-cluttered
git history as people push things, break that animal, and push followup fixes.
While that's sad, I expect the level of clutter will go down pretty quickly
and will soon be no worse than we already get from typo-fix pushes.