public inbox for [email protected]
help / color / mirror / Atom feedFrom: Noah Misch <[email protected]>
To: Robert Haas <[email protected]>
Cc: tushar <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Joe Conway <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Bossart, Nathan <[email protected]>
Cc: Stephen Frost <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: replacing role-level NOINHERIT with a grant-level option
Date: Sat, 29 Apr 2023 22:21:27 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoYkbcH=njVN-vbRDorj9VqTGNzGHCYizO_5k1RWxGOQfQ@mail.gmail.com>
References: <CAC6VRoZLfROLLsCOVkOSmPRwRS5h4Wyw_ntwaQ1K9s_HQp9Y+w@mail.gmail.com>
<CA+Tgmobep7Zi1MCKhhUa1HnJZahf+Zj3aP7OoPAQzcAvEv56cw@mail.gmail.com>
<[email protected]>
<CA+TgmoauWDcn53qwUNR_ohof1HPoVhoP12xtAMC0FiObZvpVcw@mail.gmail.com>
<[email protected]>
<CA+Tgmob6pVopLZ+NJuy_AxDS0uvgHhjjEBYQTBZXek-vM9dmGw@mail.gmail.com>
<[email protected]>
<CA+TgmobWFL5eU=60egYuzL0C0cgaVFEOVriTk_Rbs_cpj=MreQ@mail.gmail.com>
<[email protected]>
<CA+TgmoYkbcH=njVN-vbRDorj9VqTGNzGHCYizO_5k1RWxGOQfQ@mail.gmail.com>
On Thu, Aug 25, 2022 at 10:19:39AM -0400, Robert Haas wrote:
> I read through this again and found a comment that needed to be
> updated, so I did that, bumped catversion, and committed this.
[commit e3ce2de]
> @@ -4735,8 +4735,8 @@ initialize_acl(void)
>
> /*
> * In normal mode, set a callback on any syscache invalidation of rows
> - * of pg_auth_members (for roles_is_member_of()), pg_authid (for
> - * has_rolinherit()), or pg_database (for roles_is_member_of())
> + * of pg_auth_members (for roles_is_member_of()) pg_database (for
> + * roles_is_member_of())
> */
> CacheRegisterSyscacheCallback(AUTHMEMROLEMEM,
> RoleMembershipCacheCallback,
I agree one could remove the "CacheRegisterSyscacheCallback(AUTHOID, ...)".
This updated the comment as though the patch were including that removal, but
AUTHOID remains. Also, that comment needs s/pg_database/or &/.
These sites didn't change in v16 and may or may not warrant change:
doc/src/sgml/catalogs.sgml:1522: <structfield>rolinherit</structfield> <type>bool</type>
doc/src/sgml/system-views.sgml:2585: <structfield>rolinherit</structfield> <type>bool</type>
src/include/catalog/pg_authid.h:36: bool rolinherit; /* inherit privileges from other roles? */
I likely would leave pg_authid.h as-is but change the doc/ phrases.
https://postgr.es/m/17901-93eacb513e503f43%40postgresql.org led me to notice
that v16 always inherits the implicit membership in role pg_database_owner,
with no way to override like one could in v15. That message's test procedure
doesn't "fail" in v16. I think that's fine, but I'm mentioning it since
pg_database_owner didn't appear upthread.
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: replacing role-level NOINHERIT with a grant-level option
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox