public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alvaro Herrera <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: MERGE lacks ruleutils.c decompiling support!?
Date: Fri, 5 May 2023 18:21:30 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>

On 2023-May-05, Tom Lane wrote:

> I made this function:
> 
> CREATE OR REPLACE FUNCTION test_fun()
> RETURNS void
> LANGUAGE SQL
> BEGIN ATOMIC
> MERGE INTO target
> USING source s on s.id = target.id
> WHEN MATCHED THEN
>   UPDATE SET data = s.data
> WHEN NOT MATCHED THEN
>   INSERT VALUES (s.id, s.data);
> end;
> 
> It appears to work fine, but:
> 
> regression=# \sf+ test_fun()
> ERROR:  unrecognized query command type: 5
> 
> and it also breaks pg_dump.  Somebody screwed up pretty badly
> here.  Is there any hope of fixing it for Monday's releases?
> 
> (I'd guess that decompiling the WHEN clause would take a nontrivial
> amount of new code, so maybe fixing it on such short notice is
> impractical.  But ugh.)

Hmm, there is *some* code in ruleutils for MERGE, but clearly something
is missing.  Let me have a look ...

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: MERGE lacks ruleutils.c decompiling support!?
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox