Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvWe2-0002bt-QK for pgsql-hackers@arkaria.postgresql.org; Sun, 07 May 2023 05:09:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pvWe1-0000Qk-Hy for pgsql-hackers@arkaria.postgresql.org; Sun, 07 May 2023 05:09:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvWe0-0000Qa-QC for pgsql-hackers@lists.postgresql.org; Sun, 07 May 2023 05:09:12 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pvWdu-000yKW-7K for pgsql-hackers@lists.postgresql.org; Sun, 07 May 2023 05:09:11 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-64115e652eeso28004190b3a.0 for ; Sat, 06 May 2023 22:09:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683436145; x=1686028145; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=U6Abl9rU5vaSNXQ9wKF/fyScXEjgBHntO56WGeygIGE=; b=bJQrBC90BQWlk28gef75PCa5ui517jvJd9gjBniwzxFxOiVxDnHuPl6gGXP0I/Ux3t 8RJ0LLQUrdh20qDOETnuGl8UiynJRQhXLuSYwj52wKqsH5IbGBm79HsT+TtWq4YbdMEj zmffyLsTwicRe8FbGLQ5E+RqdoomR30B/vzZ2bHXIQ7W7uBjHI7JeWYeoWVAwr2UljRe HCzASYt4M9OOjQwh0sAMxOWK067EBdlnQ6F3jaCN66E+UfNPxrIIxYE5CyKUCdlh4vtc y+Iu+ddFs2HrKOmxuVT7QZjQNJkjdTd1FbP/bOcPhDguqrThK60/R3+9TiBNOA5h9yGw kAJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683436145; x=1686028145; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U6Abl9rU5vaSNXQ9wKF/fyScXEjgBHntO56WGeygIGE=; b=duy82RiwaI3ocjwyjOM3oJvqYFovrcPG99QRBzxTS+166K5sWc/20CmLccCHnCJl6r xRRoOwmqTiO9sE3w7TYL2CBKcoAiKQe6KMqJcL3pEZHgeHY3G5rum0hl5FONR3CmXY2Y FrH5lrequ8T6L32Iit3xPX3qnX5nfjXaaqtcDSCtssftC8psgvS213DBYN8dkm9ixsyy jlxi5/MtuNMwWhKhuEmB1osmgMNENYOGRLo39upVxOZOSk7XWuASK2OCHPxIL22egeND P+U113ezbUJsM49vt7bl9fXnFcPFTjJ0tKx1519VzKlHoeFmfRWY9b7iTxyzRn/BeZbI svhQ== X-Gm-Message-State: AC+VfDwNzuD0WvK1cQSGx4WxdP+IhR9YpI0LT0wjad2hpHp/MEYJ2mF3 nfcejS5tQej+GunE2s34+1o= X-Google-Smtp-Source: ACHHUZ7r6wrF2x13vWW5hUHUMYkvgfDXAOp7xA1uRJzw86NXXYSGOSN71hu3C9kwlInc2B9lWXIZ/Q== X-Received: by 2002:a17:902:f804:b0:1a6:d9a6:a9b4 with SMTP id ix4-20020a170902f80400b001a6d9a6a9b4mr7067269plb.3.1683436145027; Sat, 06 May 2023 22:09:05 -0700 (PDT) Received: from jrouhaud (2001-b011-1005-7f5e-2841-fd0a-9081-6008.dynamic-ip6.hinet.net. [2001:b011:1005:7f5e:2841:fd0a:9081:6008]) by smtp.gmail.com with ESMTPSA id p2-20020a170902bd0200b001a6c15cad12sm4489441pls.166.2023.05.06.22.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 22:09:04 -0700 (PDT) Date: Sun, 7 May 2023 13:08:59 +0800 From: Julien Rouhaud To: Tomas Vondra Cc: Alvaro Herrera , Justin Pryzby , Matthias van de Meent , pgsql-hackers@lists.postgresql.org Subject: Re: Missing update of all_hasnulls in BRIN opclasses Message-ID: <20230507050859.e7zg2zd4r4vjrnr2@jrouhaud> References: <20230424153648.cyaifmcchslbcsrf@alvherre.pgsql> <491ba86b-6294-37bb-fe00-c91e829dfc82@enterprisedb.com> <141202ca-4c92-e294-0bfe-e1709ee2f71b@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <141202ca-4c92-e294-0bfe-e1709ee2f71b@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Sun, May 07, 2023 at 12:13:07AM +0200, Tomas Vondra wrote: > > c) ignore the issue - AFAICS this would be an issue only for (external) > code accessing BrinMemTuple structs, but I don't think we're aware of > any out-of-core BRIN opclasses or anything like that ... FTR there's at least postgis that implments BRIN opclasses (for geometries and geographies), but there's nothing fancy in the implementation and it doesn't access BrinMemTuple struct.