Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q11eQ-0005DF-V0 for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 09:16:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q11eP-0003Bp-R3 for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 09:16:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q11eP-0003Bc-HD for pgsql-hackers@lists.postgresql.org; Mon, 22 May 2023 09:16:21 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q11eJ-001KfX-JE for pgsql-hackers@postgresql.org; Mon, 22 May 2023 09:16:19 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 06D98320046F; Mon, 22 May 2023 05:16:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 22 May 2023 05:16:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1684746972; x= 1684833372; bh=Oabk7Vm73PUZiwnpKbFx/qiFvFGoLdoMS3FsBe34TZQ=; b=y h/AufdJPZR1p2FRKTYzpWs1lAIpI3MhNl6JXjOZaoMa31KTPoDyw/BnLiAF7A+Zm bp3Q7NuApOrh7u+8t7dn9rlcLzMqa4rh00xT1uRWltnDJBKx3oATroJldWKN+MZl qeiwUjxMPqt099gzmqlq0rFbzTLLNZQDBsr0faXDrdkkgWtULph6jVH2tXE+Gpxn 20QUjhep9XIiDuCpA0UnV+nQCkIF7gkai51wZUCTVobPLmWxgGHFV+gkiqZDGJ2M WSNcnEzz4J3yPMegW8+RPYIPLD4oBTTLX5YbkiGsmACWjnLy94a0lQJh5y6MNo86 7vo2lMjYmuPr3JSQaD/1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejuddguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 May 2023 05:16:11 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id EF88E38B; Mon, 22 May 2023 11:16:09 +0200 (CEST) Date: Mon, 22 May 2023 11:16:09 +0200 From: Alvaro Herrera To: Stephen Frost Cc: Tom Lane , Abhijit Menon-Sen , Nathan Bossart , Bruce Momjian , pgsql-hackers@postgresql.org Subject: Re: Naming of gss_accept_deleg Message-ID: <20230522091609.nlyuu4nolhycqs2p@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I noticed that the value that enables this feature at libpq client side is 'enable'. However, for other Boolean settings like sslsni, keepalives, requiressl, sslcompression, the value that enables feature is '1' -- we use strings only for "enum" type of settings. Also, it looks like connectOptions2() doesn't validate the string value. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ really, I see PHP as like a strange amalgamation of C, Perl, Shell inflex: you know that "amalgam" means "mixture with mercury", more or less, right? i.e., "deadly poison"