Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q17HY-0006FE-BF for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 15:17:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q17HX-0004nO-7z for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 15:17:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q17HW-0004nF-5S for pgsql-hackers@lists.postgresql.org; Mon, 22 May 2023 15:17:06 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q17HT-001EHC-Ak for pgsql-hackers@postgresql.org; Mon, 22 May 2023 15:17:04 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0B9725C0139; Mon, 22 May 2023 11:17:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 22 May 2023 11:17:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1684768621; x= 1684855021; bh=5vMKU1OpGDzUwcMMJaDBN1IMbD9DMorfhXy3h36Tk48=; b=K cqFK707OwP5KuDOE2GJN0joT/ZOlHR/WWdgIRCfEVt4mc3DVTC07L65EeJRK6Jwh 5bO21XClNZqsjQbja6F3DtKTbS6BNEJf0/hHO9kJjLkGPLbZK5l9q4FUQ8Y2ToXX /s3sTSSzMnj5ratMpn/D2uNyoMLL5NFkkPNvxuKZ4ErBpjx7WjZ8K9pKuswTNf4M Z84CRK/5/ziDsz3Z26xXVbxFdvvVt4xofSoUYjll/V/7fXunVXcYtqGh+MbFxDrS lWcK4c6lPW5dONNVtDCQHpZaInhLl8Cq1YitvXgAurUknRU3BG7heJxYpmo8XkvT LzYL6r8Rkfn7f81Gpgeow== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejuddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 May 2023 11:17:00 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id E06A238B; Mon, 22 May 2023 17:16:57 +0200 (CEST) Date: Mon, 22 May 2023 17:16:57 +0200 From: Alvaro Herrera To: Tristan Partin Cc: pgsql-hackers@postgresql.org Subject: Re: Add missing includes Message-ID: <20230522151657.vincyjdi56uedfhk@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-May-22, Tristan Partin wrote: > Some files were missing information from the c.h header. Actually, these omissions are intentional, and we have bespoke handling for this in our own header-checking scripts (src/tools/pginclude). I imagine this is documented somewhere, but ATM I can't remember where. (And if not, maybe that's something we should do.) -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/