Feedback-ID: id4a34324:Fastmail
Date: Wed, 7 Jun 2023 16:47:26 -0700
From: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: win32ver data in meson-built postgres.exe
Message-ID: <20230607234726.gqvydjl6qamoyq2k@awork3.anarazel.de>
References: <20230607231407.GC1334487@rfd.leadboat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230607231407.GC1334487@rfd.leadboat.com>
Archived-At: <https://www.postgresql.org/message-id/20230607234726.gqvydjl6qamoyq2k%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-06-07 16:14:07 -0700, Noah Misch wrote:
> A postgres.exe built with meson, ninja, and MSVC lacks the version metadata
> that postgres.exe gets under non-meson build systems.  Patch attached.

I dimly recall that we discussed that and basically decided that it doesn't
really make sense to attach this information to postgres.exe.


>     This preserves two quirks of the older build systems.  First,
>     postgres.exe is icon-free.

We could also just change that.


>     Second, the resources object is not an input
>     to postgres.def.

I don't see what negative effects that could have: postgres.def is used to
provide symbol "thunks" to extension libraries, which don't need to access
this information.  If we used the rc compiler to inject binary data (say
bootstrap.bki) into binaries, it'd possibly be a different story (although I
think it might work anyway) - but if we wanted to do something like that, we'd
build portable infrastructure anyway.


> -  rcgen_bin_args = rcgen_base_args + [
> +  rcgen_server_args = rcgen_base_args + [
>      '--VFT_TYPE', 'VFT_APP',
> -    '--FILEENDING', 'exe',
> +    '--FILEENDING', 'exe'
> +  ]
> +
> +  rcgen_bin_args = rcgen_server_args + [
>      '--ICO', pg_ico
>    ]

Somehow it seems a bit wrong to derive non-server from server, but ... ;)


Greetings,

Andres Freund