Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7gBC-0007kU-9q for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Jun 2023 17:45:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q7gBA-0005x7-B5 for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Jun 2023 17:45:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7gB8-0005wx-Nn for pgsql-hackers@lists.postgresql.org; Fri, 09 Jun 2023 17:45:40 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7gB3-001G7F-RD for pgsql-hackers@postgresql.org; Fri, 09 Jun 2023 17:45:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 844EA3200A0E; Fri, 9 Jun 2023 13:45:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 09 Jun 2023 13:45:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1686332730; x=1686419130; bh=g4 6lIZOukpLqfdIRhfjArw+/KS45vm+1I+hSWI7+xWw=; b=GQ+Ts2hSug+1xiiny3 1r30h/N+T64piso+8DQHRU2VyOr5AF/B64rYSIEohQqDcZJg5Q+Lyw9TgIvZUxnl okVMO1UxlfKUiG8NRgdOQxDsvCgaIBT1kRzFunzXRXBnFSbf45OaOriZPUOGYsLj d/aHelpnshlqHGYuJi+0GrF9Cyu2KABKxPfOlCOR6MC7vkI3Iw/xA7geCdT4SXkR meCsckd8uOdvb2oke/9LsXoPldbt5+UD++bUhdHzBihUL4B0O2mRssjITKcs5ike jYTx7tB4wd3gUdXpLVOFmjHqNCWOGFEIDgdToOsnPJ6uXfTGgK7A0s41LzfzRnRx sN+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1686332730; x=1686419130; bh=g46lIZOukpLqf dIRhfjArw+/KS45vm+1I+hSWI7+xWw=; b=swG/CmBbY9ZUHH5F6dNy9+T4203EJ Zx0FFPnhL1eUBa5cF2vDD9wDeMR2jRhzlw09XGkju/4vhhjptHrYpnPBXyNcf29l pbcivo1CDsg+BMJKzUiaxQfNeGhx2bAZC95bcwMzihYpeaoKV11fAXPv9QDdLjgz i/zV/RhKJJNT1EOyvUB+JQkzSn0tKGexvGjY3lkLvSL0FoD1h/lR7pdB6M7LNRme 8zClZz9wt9KgAZDzZUYfH6LAIL/wp0Hja6GZt86HQCYheJJc8tWBmL+HPHvQwLxm B+6raT7vJL73J/mMus3M5Fg4O+mdQWgU+g/S7weiqAqM5D8E8u1kkUcOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgedtkedgudduiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpeegteevjeduueduuefhfedtffehtefgvedufedtfeevgfeifefgjedu vdffgeefkeenucffohhmrghinhepphhoshhtghhrrdgvshenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvshesrghnrghrrgiivghl rdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Jun 2023 13:45:29 -0400 (EDT) Date: Fri, 9 Jun 2023 10:45:27 -0700 From: Andres Freund To: Noah Misch Cc: pgsql-hackers@postgresql.org Subject: Re: win32ver data in meson-built postgres.exe Message-ID: <20230609174527.lldrmg6p5emqp32t@awork3.anarazel.de> References: <20230607231407.GC1334487@rfd.leadboat.com> <20230607234726.gqvydjl6qamoyq2k@awork3.anarazel.de> <20230608014507.GD1334487@rfd.leadboat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608014507.GD1334487@rfd.leadboat.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-06-07 18:45:07 -0700, Noah Misch wrote: > On Wed, Jun 07, 2023 at 04:47:26PM -0700, Andres Freund wrote: > > On 2023-06-07 16:14:07 -0700, Noah Misch wrote: > > > A postgres.exe built with meson, ninja, and MSVC lacks the version metadata > > > that postgres.exe gets under non-meson build systems. Patch attached. > > > > I dimly recall that we discussed that and basically decided that it doesn't > > really make sense to attach this information to postgres.exe. > > I looked for a discussion behind that, but I didn't find it. A key > user-visible consequence is whether the task manager "Name" column shows (1) > "PostgreSQL Server" (version data present) vs. (2) "postgres.exe" (no version > data). While (2) is not terrible, (1) is more typical on Windows. I don't > see cause to migrate to (2) after N years of sending (1). Certainly this part > of the user experience should not depend on one's choice of build system. I think I misremembered some details... I guess I was remembering the icon for dlls, in https://postgr.es/m/20220829221314.pepagj3i5mj43niy%40awork3.anarazel.de Touching the rc stuff always makes me feel dirty enough that I want to swap it out of my brain, if not run some deep erase tool :) > > > This preserves two quirks of the older build systems. First, > > > postgres.exe is icon-free. > > > > We could also just change that. > > I would be +1 for that (only if done for all build systems). Showing the > elephant in task manager feels better than showing the generic-exe icon. Let's do that then. Greetings, Andres Freund