Date: Sat, 10 Jun 2023 21:18:57 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Steele <david@pgmasters.net>,
	Amit Langote <amitlangote09@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Views no longer in rangeTabls?
Message-ID: <20230610131857.cqrsm6pwq3k47yuv@jrouhaud>
References: <3953179e-9540-e5d1-a743-4bef368785b0@pgmasters.net>
 <CA+HiwqFC0xDCCiXbUjb-xisxo9PPuA8_ykn8Fz+6RbBJBE8mVA@mail.gmail.com>
 <462cd5de-3ade-989b-0798-7e1cab562991@pgmasters.net>
 <470644.1686327286@sss.pgh.pa.us>
 <edb0f313-648e-bbca-5ce0-225b9cce046d@pgmasters.net>
 <CA+HiwqFaMfM-082vwNYSAWU13T9nd62DObeNLbSTisSh6odOog@mail.gmail.com>
 <b8a0b834-c936-d135-df66-cc119ceb8205@pgmasters.net>
 <625519.1686401807@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <625519.1686401807@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20230610131857.cqrsm6pwq3k47yuv%40jrouhaud>
Precedence: bulk

On Sat, Jun 10, 2023 at 08:56:47AM -0400, Tom Lane wrote:
>
> Well, if we're gonna do it we should do it for v16, rather than
> change the data structure twice.  It wouldn't be hard exactly:
>
>     /*
>      * Clear fields that should not be set in a subquery RTE.  Note that we
>      * leave the relid, rellockmode, and perminfoindex fields set, so that the
>      * view relation can be appropriately locked before execution and its
>      * permissions checked.
>      */
> -   rte->relkind = 0;
>     rte->tablesample = NULL;
>     rte->inh = false;            /* must not be set for a subquery */
>
> plus adjustment of that comment and probably also the comment
> for struct RangeTblEntry.

and also handle that field in (read|out)funcs.c