Date: Mon, 12 Jun 2023 14:37:15 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, sfrost@snowman.net,
	alvherre@alvh.no-ip.org, andres@anarazel.de,
	jchampion@timescale.com, john.naylor@enterprisedb.com,
	masao.fujii@oss.nttdata.com, noriyoshi.shinoda@hpe.com,
	pgsql-hackers@postgresql.org, rjuju123@gmail.com,
	sawada.mshk@gmail.com, tgl@sss.pgh.pa.us, thomas.munro@gmail.com
Subject: Re: Improve logging when using Huge Pages
Message-ID: <20230612213715.GA178071@nathanxps13>
References: <ZBfsbTEUnRcEyNao@paquier.xyz>
 <ZBplvQx7n0MGVr6O@telsasoft.com>
 <ZBqwHY7yZQATAp9N@paquier.xyz>
 <ZBt+tCS/Akj8BvHi@telsasoft.com>
 <ZBt/4EdbwLp2hJLx@paquier.xyz>
 <20230420211617.GA1435672@nathanxps13>
 <ZFByzj4BUTE+sdhs@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZFByzj4BUTE+sdhs@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20230612213715.GA178071%40nathanxps13>
Precedence: bulk

On Tue, May 02, 2023 at 11:17:50AM +0900, Michael Paquier wrote:
> On Thu, Apr 20, 2023 at 02:16:17PM -0700, Nathan Bossart wrote:
>> AFAICT this would involve adding a bool to BackendParameters and using it
>> in save_backend_variables() and restore_backend_variables(), which is an
>> additional 3 lines of code.  That doesn't sound too bad to me, but perhaps
>> I am missing something.
> 
> Appending more information to BackendParameters would be OK, still
> this would require the extra SQL function to access it, which is
> something that pg_settings is able to equally offer access to if
> using a GUC.

Fair enough.  I know I've been waffling in the GUC versus function
discussion, but FWIW v7 of the patch looks reasonable to me.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com