Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8qi8-000789-OI for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Jun 2023 23:12:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q8qi7-00048Q-CD for pgsql-hackers@arkaria.postgresql.org; Mon, 12 Jun 2023 23:12:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8qi7-00048H-2s for pgsql-hackers@lists.postgresql.org; Mon, 12 Jun 2023 23:12:31 +0000 Received: from mail-oa1-x30.google.com ([2001:4860:4864:20::30]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q8qi2-0020wG-Gn for pgsql-hackers@lists.postgresql.org; Mon, 12 Jun 2023 23:12:30 +0000 Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-1a5229df1f2so3100679fac.3 for ; Mon, 12 Jun 2023 16:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686611544; x=1689203544; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Wfz1VFp/ZdsW1fAfwp59JKmKxbc5qfajo3/d7gyFk3w=; b=eONA8gcYRbEt9pij6yEINLIkiTrvzp49fDsJrarjP8lgV4uakONqfJZRWiqztTkBkz iS5LztdpR1iLdNzaQ9Nhv1PtNidurWfzQw/9UeuBWW8lVqdHoNYsMK1WvzOUsAozSNSk RnT8IfDlOQ8oLGtjqaIqhtqJJvZy+JlZ+YMRt0JXlAGg6RV8ATXb2RAL5/RQs84X2XpO uegCbTHZHKpivgpPa+pxpM8lD+Oputj5TpfOLVngy8biHvD2Fc8X/XGwMeLCzwr32vSz Zkkroj0DaWm5n4X0KrybFVNmqbWeKcqzk/Vggfzr6C9KTAEy4mOYUfA6wB+p7F4Ju3KK +rsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686611544; x=1689203544; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Wfz1VFp/ZdsW1fAfwp59JKmKxbc5qfajo3/d7gyFk3w=; b=I3X3jltAgYYYs2offyb8ZHyP6oovTNBSxu53S8lTQ1YbP9BB3ztlRO+bE7z9DM5NqO LyHUFElswNQ9wpJM6Jpyph+8Y+uVNT1c7huwNJQNouj0a/2QKup0oHNcahUzUiSOpq5J +P/HHu8GKgn5gmnjfOHohjc2uokiReydPoRZhYzX7pJR3KOIUUHua65YP4WJzety9ieg 94WwjnvAkaykgcBw5X4QnagLXy5GjGolFOactFR3shMVuaRw/vd4zAreX2akzX4vYs6N e6pV7F4Zau9WITF832mCzILYWkPNjEsWlth3LruBzBVqVfT6lORg5ljCXi2bBt3iXlft ucaQ== X-Gm-Message-State: AC+VfDwP9Fg5pICE8oaombotpVdf0nioTzvvtfctuLGWP5Cu2DQefnCb 38Y5DtifIi6t8c+F92Sh9gUJmbb06bA= X-Google-Smtp-Source: ACHHUZ6MmOEEy6uGSA/qRzM0GasADblW+jmvN8NBHPxRmR8q11xEosZDPg5tv2559vsggWoayN4ZVw== X-Received: by 2002:a05:6870:8645:b0:1a6:4c71:8d8 with SMTP id i5-20020a056870864500b001a64c7108d8mr6302769oal.31.1686611544588; Mon, 12 Jun 2023 16:12:24 -0700 (PDT) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id q23-20020a62ae17000000b0065992d334f4sm7609620pff.177.2023.06.12.16.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 16:12:23 -0700 (PDT) Date: Mon, 12 Jun 2023 16:12:22 -0700 From: Nathan Bossart To: Daniel Gustafsson Cc: PostgreSQL Hackers , Andrew Dunstan Subject: Re: Setting restrictedtoken in pg_regress Message-ID: <20230612231222.GA180938@nathanxps13> References: <62A63C81-3893-4E3F-A34E-2081DF67074E@yesql.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62A63C81-3893-4E3F-A34E-2081DF67074E@yesql.se> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Aug 30, 2022 at 03:02:54PM +0200, Daniel Gustafsson wrote: > In pg_regress we set restrictedToken when calling CreateRestrictedProcess, but > we never seem to use that anywhere. Not being well versed in Windows I might > be missing something, but is it needed or is it a copy/pasteo from fa1e5afa8a2 > which does that in restricted_token.c? If not needed, removing it makes the > code more readable IMO. Looks reasonable to me. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com