Date: Tue, 13 Jun 2023 16:54:42 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Jeff Davis <pgsql@j-davis.com>, Ted Yu <yuzhihong@gmail.com>,
	Pavel Luzanov <p.luzanov@postgrespro.ru>,
	Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: allow granting CLUSTER, REFRESH MATERIALIZED VIEW, and REINDEX
Message-ID: <20230613235442.GA222795@nathanxps13>
References: <20221218233018.GA1476904@nathanxps13>
 <20230103234549.GA289060@nathanxps13>
 <20230109225157.GA1288965@nathanxps13>
 <7d2a8b72e23c8236281c6e00ae790327f965a8e5.camel@j-davis.com>
 <20230113203334.GA2206335@nathanxps13>
 <e25c84fafae4eb08d8a6e83207678096bac102d6.camel@j-davis.com>
 <20230113225626.GA2380176@nathanxps13>
 <20230113231339.GA2422750@nathanxps13>
 <20230613211246.GA219055@nathanxps13>
 <ZIj4v1CwqlDVJZfB@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZIj4v1CwqlDVJZfB@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/20230613235442.GA222795%40nathanxps13>
Precedence: bulk

On Wed, Jun 14, 2023 at 08:16:15AM +0900, Michael Paquier wrote:
> While on it, this buzzes me:
>  static bool
> -vacuum_rel(Oid relid, RangeVar *relation, VacuumParams *params)
> +vacuum_rel(Oid relid, RangeVar *relation, VacuumParams *params, bool skip_privs)
> 
> VacuumParams has been originally introduced to avoid extending
> vacuum_rel() with a bunch of arguments, no?

Yeah, that could probably be moved into VacuumParams.

> So, yes, agreed about the removal of has_partition_ancestor_privs().
> I am adding an open item assigned to you and Jeff.

Thanks.  I suspect there's more discussion incoming, but I'm hoping to
close this item one way or another by 16beta2.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com