Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9ExU-0002sY-Af for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 01:06:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9ExS-0003Zz-PO for pgsql-hackers@arkaria.postgresql.org; Wed, 14 Jun 2023 01:05:58 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9ExS-0003Zq-GM for pgsql-hackers@lists.postgresql.org; Wed, 14 Jun 2023 01:05:58 +0000 Received: from mail-ot1-x333.google.com ([2607:f8b0:4864:20::333]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q9ExP-0024AH-Nx for pgsql-hackers@postgresql.org; Wed, 14 Jun 2023 01:05:57 +0000 Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6b2d8b5fde6so2452822a34.2 for ; Tue, 13 Jun 2023 18:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686704754; x=1689296754; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=64oGQ6cTdl7rQq/ETxK8leneSTCSihl9Bv+7Yc9SRpo=; b=ATTiNUhRQeFXS//nz96uedssSXzuaec2ChIQewOMakyExAOj8TEowk/MjrJf+BXep9 IWgr2ko1wZds8XG6+YGhXb9Q+kBTC5uwfB61BbIo22DskJw5tpqU3S7/UwRl0M/8F3Bh a329SpATvGGY62V4hEMTwN6GtLhQLWdBxz4PKssJncFzjXFuTGGLxlLssLC2mETiss7y sgAdqxVP4eWLroC1GbIMmT6TANA6xYvWlockd2KpoOLoLDxdi2lgDBeOFJKCB+oXPjFg FfeXNIEKLf1grk/x91yaXp8t3jMyjW2tVWJ8aqOYiLsEQhO/l4abACRL3waa2abYqi48 P6RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686704754; x=1689296754; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=64oGQ6cTdl7rQq/ETxK8leneSTCSihl9Bv+7Yc9SRpo=; b=M968hTXNVSQQQdQqGLYTLcGq2su4ACpIFrS1RayqwzotBHAAQYmG5ay4Pou9iGhJgc 84rPnby+uu+JIKTG/1ZgIAWdiDE4RJGDLhgOG+Rmowu1s/TsbmjYeI5ovc+N0uaNJAEW ky8nwaeVQaO5R0T70ihVF1x9nKOT+Bmi/y38rTlQdPaE6D+5M3XibpemWN2/nSES54LQ M6F+BqhSIU1+hrzCSadcZ50DyTKdR8WdXTXC/ys5IBcOr/VX437zal+zRVjJJPihJ98f M5Q5vTRLmqZiL5O1/oquivPZ0LHWQwoXPdjtwC2k/5CwrqXTztfKL3lYXGZN+v/ufHQb D5zw== X-Gm-Message-State: AC+VfDwd63osVHu9pQ34uHH0hP4e6DMSO7FpTXB62jh2wgyiaMqQNmix Hy+MdlZ/RkhOeJNDd1sEr6A= X-Google-Smtp-Source: ACHHUZ4Lqi6XVD+6zWhe0z4t1JOVbQ7H3lRYjsab23Mi2nQG+EgUZU7TuKLkLhAxMkkDxf01hsD3Cw== X-Received: by 2002:a05:6358:ce14:b0:12b:dbed:e021 with SMTP id gt20-20020a056358ce1400b0012bdbede021mr5303138rwb.31.1686704754245; Tue, 13 Jun 2023 18:05:54 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id e1-20020aa78c41000000b0064fabbc047dsm9168821pfd.55.2023.06.13.18.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 18:05:53 -0700 (PDT) Date: Wed, 14 Jun 2023 10:05:51 +0900 (JST) Message-Id: <20230614.100551.1518568145455620693.horikyota.ntt@gmail.com> To: ranier.vf@gmail.com Cc: gurjeet@singh.im, guofenglinux@gmail.com, pgsql-hackers@postgresql.org Subject: Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c) From: Kyotaro Horiguchi In-Reply-To: <20230614.100159.450192360046344001.horikyota.ntt@gmail.com> References: <20230614.100159.450192360046344001.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 27.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Wed, 14 Jun 2023 10:01:59 +0900 (JST), Kyotaro Horiguchi wrote in > If we decide to remove it, the preceding blank line seems to be a > separator from the previous function call. So, we might want to Mmm. that is a bit short. Anyway I meant that the blank will become useless after removing the comment. > consider removing that blank line, too. > > Otherwise it LGTM. regards. -- Kyotaro Horiguchi NTT Open Source Software Center