Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9yUz-0003cy-6S for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Jun 2023 01:43:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q9yUy-0006my-3o for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Jun 2023 01:43:36 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9yUx-0006mo-Qk for pgsql-hackers@lists.postgresql.org; Fri, 16 Jun 2023 01:43:35 +0000 Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q9yUv-002fjS-CS for pgsql-hackers@lists.postgresql.org; Fri, 16 Jun 2023 01:43:35 +0000 Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1a1fa977667so332347fac.1 for ; Thu, 15 Jun 2023 18:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686879811; x=1689471811; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=FtW03YCUa7/uX14xYPfgTHUonXsVmZSLnH3QdkFavU0=; b=Ik1zAql3upeZK0D+pzxgtav9d1ATmLWmgcPpkU/k9+R/EsgqC4HkOd2tBextvsR9D0 33dwv9MFBt39vQXq6fIZKHog9trvrvYnSDUm0F7PWpkHk8xRmHkiHl7fYw9NZjnVCzjE HuRSMHh9JGbciULrMaF479j0gbg+G/3+Lvvubq30PehFb1R1mu/vKIzAjY/GpiEjgWFL cccjvz9vu8pMmThw4BxrFPKWVt8whxTJ29u0p5Tv+QfO/WnDpoFMo0nT5EvVmfZav1W7 UdVRRuPWolTPA1/1bM4AvykpeBB6VEVQLuJT2pTaVes9ZFwi8lJUKvJwoIBEF/fsnkW1 4Z6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686879811; x=1689471811; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FtW03YCUa7/uX14xYPfgTHUonXsVmZSLnH3QdkFavU0=; b=hxEJWq0DhCMIaxR0wMemK+yxcobsUxxl4jmj++4sypRYbWWRfpQsJtUcecQLtvkemn 9nml5iLaFnSh0EY91TEhPKwR6A6hTCUo8QZP3tceDoSzWKzCnYC/RzKUFaVrCJE71BfJ OSLeOYKpQzW85doIQehEhHrZBeCkKF06coo/I9sNL9CJMVUAPOSQpGsqRbQ02Ayjans9 BDTW480bcBfFL8LURq4GbD/OuHAOEx7wV4HdJYEbrH4Dyvg+gBG98WLnL5F3elqLRfga LFUNNg/XmAMmK8/vYEfOJ/zSxz0qCZVMk/OrmrpSRJrmE0AFKw0T3br/TgJNbsxtPC8j g8cA== X-Gm-Message-State: AC+VfDyJ8fAKSNUn9jIyRGuellG831IAmEHXVgrdqpOXhfyXlPhgykQM OVyIDYt7wfmo6038sXH6ZQE= X-Google-Smtp-Source: ACHHUZ4fvqmXne1AsUJCpQTFCtOrIEaYfnWFnKQ0R88ukjONwry+BFDIgX1yz//RLXMWbtalfenLbw== X-Received: by 2002:a05:6870:e1c3:b0:19e:475:9df1 with SMTP id g3-20020a056870e1c300b0019e04759df1mr756486oab.27.1686879811120; Thu, 15 Jun 2023 18:43:31 -0700 (PDT) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id d2-20020a17090a02c200b0025bc49aa716sm257668pjd.27.2023.06.15.18.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 18:43:30 -0700 (PDT) Date: Fri, 16 Jun 2023 10:43:27 +0900 (JST) Message-Id: <20230616.104327.1878440413098623268.horikyota.ntt@gmail.com> To: smithpb2250@gmail.com Cc: pgsql-hackers@lists.postgresql.org Subject: Re: Consistent coding for the naming of LR workers From: Kyotaro Horiguchi In-Reply-To: References: User-Agent: Mew version 6.8 on Emacs 27.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk At Thu, 15 Jun 2023 12:42:33 +1000, Peter Smith wrote in > It is better to have a *single* point where these worker names are > defined, so then all output uses identical LR worker nomenclature. > > PSA a small patch to modify the code accordingly. This is not intended > to be a functional change - just a code cleanup. > > Thoughts? I generally like this direction when it actually decreases the number of translatable messages without making grepping on the tree excessively difficult. However, in this case, the patch doesn't seems to reduce the translatable messages; instead, it makes grepping difficult. Addition to that, I'm inclined to concur with Alvaro regarding the gramattical aspect. Consequently, I'd prefer to leave these alone. regards. -- Kyotaro Horiguchi NTT Open Source Software Center