Feedback-ID: id4a34324:Fastmail
Date: Fri, 16 Jun 2023 14:16:28 -0700
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Tristan Partin <tristan@neon.tech>,
	Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= <ilmari@ilmari.org>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Missing dep on Catalog.pm in meson rules
Message-ID: <20230616211628.3wxxt2cisexqrakq@awork3.anarazel.de>
References: <CT1MJFE3PEEV.2S08CXLDYMCWP@gonk>
 <329a690c-1f4e-4759-8018-8ee562c159f0@app.fastmail.com>
 <CT1V90ZD4ZPZ.2J5QU7ZEYSB60@gonk>
 <20230602130028.yf4jagpqqmivhx77@alap3.anarazel.de>
 <CT26U28ECWTA.3VIVYB9J55L4K@gonk>
 <20230602134704.w2gg7nwe2jisd7es@alap3.anarazel.de>
 <CT29G866OR1A.P5MR0P1UF545@gonk>
 <20230609184354.5stlrg7vfj6dd7rz@awork3.anarazel.de>
 <20230614193213.74elqlrhb24i4ouq@awork3.anarazel.de>
 <52d98dc8-8107-7f42-5793-3a3eac30ecfa@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <52d98dc8-8107-7f42-5793-3a3eac30ecfa@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/20230616211628.3wxxt2cisexqrakq%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-06-16 16:20:14 -0400, Andrew Dunstan wrote:
> Unless I'm misunderstanding, this doesn't look terribly feasible to me. You
> can only get at %INC by loading the module, which in many cases will have
> side effects.

I was envisioning using %INC after the use/require block - I don't think our
scripts load additional modules after that point?


> And then you would also need to filter out things loaded that
> are not our artefacts (e.g. Catalog.pm loads File::Compare).

I don't think we would need to filter the output. This would just be for a
build dependency file. I don't see a problem with rerunning genbki.pl et al after
somebody updates File::Compare?

Greetings,

Andres Freund