public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Postgres hackers <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Subject: Re: Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~
Date: Tue, 20 Jun 2023 22:44:59 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

Hi,

On 2023-06-21 11:53:44 +0900, Michael Paquier wrote:
> Compiling Postgres up to 13 with OpenSSL 3.0 leads to a couple of
> compilation warnings with what OpenSSL considers as deprecated, like:
> sha2_openssl.c: In function pg_sha384_init
> sha2_openssl.c:70:9: warning: SHA384_Init is deprecated =
> Since OpenSSL 3.0 [-Wdeprecated-declarations]
>    70 |         SHA384_Init((SHA512_CTX *) ctx);
>       |         ^~~~~~~~~~~
> /usr/include/openssl/sha.h:119:27: note: declared here
>   119 | OSSL_DEPRECATEDIN_3_0 int SHA384_Init(SHA512_CTX *c);
> 
> I was looking at the code of OpenSSL to see if there would be a way to
> silenced these, and found about OPENSSL_SUPPRESS_DEPRECATED.
> 
> I have been annoyed by these in the past when doing backpatches, as
> this creates some noise, and the only place where this counts is
> sha2_openssl.c.  Thoughts about doing something like the attached for
> ~13?

Wouldn't the proper fix be to backpatch 4d3db13621b? Just suppressing all
deprecations doesn't strike me as particularly wise, especially because we've
chosen a different path for 14+?

Greetings,

Andres Freund

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox