public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kyotaro Horiguchi <[email protected]>
To: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
Date: Tue, 27 Jun 2023 16:39:52 +0900 (JST)
Message-ID: <[email protected]> (raw)
In-Reply-To: <ZJqInm5KoY/[email protected]>
References: <[email protected]>
<[email protected]>
<ZJqInm5KoY/[email protected]>
At Tue, 27 Jun 2023 15:58:38 +0900, Michael Paquier <[email protected]> wrote in
> On Tue, Jun 27, 2023 at 03:44:04PM +0900, Kyotaro Horiguchi wrote:
> > The file name was "LSNh-LSNl.spcOid.dbOid.relNumber.blk_forkname", but
> > the comment in the TAP script read as:
> >
> > -# XXXXXXXX-XXXXXXXX.DBOID.TLOID.NODEOID.dd_fork with the components being:
> >
> > which looks wrong. I'm not sure it is a business of this patch, though..
>
> This part is getting changed here anyway, so improving it is fine by
> me with the terms you are suggesting for these two 4-byte values in
> this comment.
I meant that the name is structured as
TLIh-TLIl.<tablespace>.<database>.<relnumber>.<blk>._<fork>, which
appears to be inconsistent with the comment. (And I'm not sure what
"TLOID" is..)
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add TLI number to name of files generated by pg_waldump --save-fullpage
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox