Date: Thu, 29 Jun 2023 13:29:40 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Noah Misch <noah@leadboat.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Fix search_path to a safe value during maintenance
 operations.
Message-ID: <20230629202940.GA2052174@nathanxps13>
References: <d20864b929ff769a0ebf772359719f05bb6982cd.camel@j-davis.com>
 <573014.1686375211@sss.pgh.pa.us>
 <20230612170510.GA201972@gust.leadboat.com>
 <f53df2dbe11bb42764bcdd003a54aa29c9bb6137.camel@j-davis.com>
 <20230613182920.GA259321@gust.leadboat.com>
 <1799839.1686687804@sss.pgh.pa.us>
 <4df537f5a0d8c0ceac3eec3809d1144880b8e76d.camel@j-davis.com>
 <CA+TgmoYtJU0KknWr11W--wK=4eJtdHOgupyT=beZVPC8P=o+YA@mail.gmail.com>
 <578fb4be80247570e6a05924908765a0b345971e.camel@j-davis.com>
 <CA+TgmoZVCHERUkXhAMT2Er-sKBc5C6_iX+TpxxivBevDHzq2TQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CA+TgmoZVCHERUkXhAMT2Er-sKBc5C6_iX+TpxxivBevDHzq2TQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230629202940.GA2052174%40nathanxps13>
Precedence: bulk

On Thu, Jun 29, 2023 at 11:19:38AM -0400, Robert Haas wrote:
> [ emerges from hibernation ]

Welcome back.

> If we're not going to fix the feature so that it doesn't break the
> security model, we should probably just revert it. I don't understand
> at all the idea of shipping something that we 100% know is broken.

Given Jeff's commit followed the precedent set by the fix for
CVE-2018-1058, I'm inclined to think he was on the right track.  Perhaps a
more targeted fix, such as only changing search_path when the command is
not run by the table owner (as suggested upthread [0]) is worth
considering.

[0] https://postgr.es/m/CAKFQuwaVJkM9u%2BqpOaom2UkPE1sz0BASF-E5amxWPxncUhm4Hw%40mail.gmail.com

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com