Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEypg-0002qX-7b for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Jun 2023 21:05:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qEype-0007rx-90 for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Jun 2023 21:05:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qEypd-0007r4-W0 for pgsql-hackers@lists.postgresql.org; Thu, 29 Jun 2023 21:05:37 +0000 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qEypZ-001EoA-06 for pgsql-hackers@postgresql.org; Thu, 29 Jun 2023 21:05:37 +0000 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1b0156a1c49so1005802fac.0 for ; Thu, 29 Jun 2023 14:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688072731; x=1690664731; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u3XFS0LgpnJQ9v/lCpoNTd7qbQ9y6fZG1PreeEd0GQM=; b=jWHPKOP6eygvm+VFatHBmpPIPXc3p+QAse5tGeBQ+mFcRNbqWBOnu3TPqT8QOrqYIM /jMMzDl0y7SFcll21mFYtr8JPCHDlqn7/bS4OhBVco2PRnKdIpQShhen9RgnM65fK/Ni /yw9Q2C2S5Yrki1YB36W4UPwdf3K1gzaHBFMAvFOExskDc05uO5oiZ7+zstscWI3u0nH Uud3kTj1DDLQdrHiKABoNfpDWjAQJoiMih33r+O9aTf5Dmh7jKargt7JgklBqk+y4Aae K9RckDM4E0cgBoVUpzvZ/RRtQ0zDhMMIlhvT9KjiYrCqfniGYZtyaZhvauO/n/nQD8R1 viBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688072731; x=1690664731; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u3XFS0LgpnJQ9v/lCpoNTd7qbQ9y6fZG1PreeEd0GQM=; b=Bt0vx9pWe8Qh+/EbH+5esgnT8RJXozToKdheMvO8UXnybVxx+9klYhZSHDRvt/hP8x jquoSQjj3v0Thr4vl+aJEU1qj2ieIsYv6tW+Gkb19rozj6BDvjr7yTshwPf3/YWEpXzO BDL5UFnn/IylpwFQArZ0b4suf3bk+AkDnwC7TR+gIm8Khz3dC2VXpcL2sG0LWBcoH7oI j9q2TE86ZSJGPzBuR9aXP+odnuIb4mEWm0rz9U2q6K/wGXzZZPupnGk6p5AESSm2WW+q YitRpQEjSAkkpqO4MDE1P/NXxuaAxNw9v67G8spyouSy0fcKdjFPQDg/rXVY2BG1ULzI 044w== X-Gm-Message-State: AC+VfDzP7fxV/dwM5wVZEtLfy54vPevsv5h/55Gc83d5T4BP+n7FfDq0 QAFgJyR53or9MW3kYmqCAWH6hhOJT9M= X-Google-Smtp-Source: ACHHUZ67RBTPME6ELXYkPffv5TBQ5/RJWnhygTY1jGQ2mJO55MEmCCSQDRUR30fcnMjid/MAUol6Rw== X-Received: by 2002:a05:6870:910b:b0:1b0:32ab:2be0 with SMTP id o11-20020a056870910b00b001b032ab2be0mr1183244oae.20.1688072730763; Thu, 29 Jun 2023 14:05:30 -0700 (PDT) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id 10-20020a17090a19ca00b0026333ad02c1sm3802764pjj.10.2023.06.29.14.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jun 2023 14:05:30 -0700 (PDT) Date: Thu, 29 Jun 2023 14:05:28 -0700 From: Nathan Bossart To: Gurjeet Singh Cc: pgsql-hackers@postgresql.org Subject: Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb Message-ID: <20230629210528.GA2055033@nathanxps13> References: <20230628045741.GA1813397@nathanxps13> <20230629052409.GB2049807@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629052409.GB2049807@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Jun 28, 2023 at 10:24:09PM -0700, Nathan Bossart wrote: > On Wed, Jun 28, 2023 at 09:20:03PM -0700, Gurjeet Singh wrote: >> Nitpicking: The patch seems to have Windows line endings, which >> explains why my `patch` complained so loudly. >> >> $ patch -p1 < v1-0001-harmonize-....patch >> (Stripping trailing CRs from patch; use --binary to disable.) >> patching file doc/src/sgml/ref/reindexdb.sgml >> (Stripping trailing CRs from patch; use --binary to disable.) >> patching file doc/src/sgml/ref/vacuumdb.sgml >> (Stripping trailing CRs from patch; use --binary to disable.) >> patching file src/bin/scripts/clusterdb.c >> (Stripping trailing CRs from patch; use --binary to disable.) >> patching file src/bin/scripts/reindexdb.c >> >> $ file v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch >> v1-0001-harmonize-....patch: unified diff output text, ASCII text, >> with CRLF line terminators > > Huh. I didn't write it on a Windows machine. I'll look into it. I couldn't reproduce this with the patch available in the archives: $ patch -p1 < v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch patching file doc/src/sgml/ref/reindexdb.sgml patching file doc/src/sgml/ref/vacuumdb.sgml patching file src/bin/scripts/clusterdb.c patching file src/bin/scripts/reindexdb.c $ file v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch v1-0001-harmonize-password-reuse-in-vacuumdb-clusterdb-an.patch: unified diff output, ASCII text -- Nathan Bossart Amazon Web Services: https://aws.amazon.com