Date: Fri, 30 Jun 2023 11:35:46 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Davis <pgsql@j-davis.com>, Robert Haas <robertmhaas@gmail.com>,
	Noah Misch <noah@leadboat.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Fix search_path to a safe value during maintenance
 operations.
Message-ID: <20230630183546.GB2828237@nathanxps13>
References: <f53df2dbe11bb42764bcdd003a54aa29c9bb6137.camel@j-davis.com>
 <20230613182920.GA259321@gust.leadboat.com>
 <1799839.1686687804@sss.pgh.pa.us>
 <4df537f5a0d8c0ceac3eec3809d1144880b8e76d.camel@j-davis.com>
 <CA+TgmoYtJU0KknWr11W--wK=4eJtdHOgupyT=beZVPC8P=o+YA@mail.gmail.com>
 <578fb4be80247570e6a05924908765a0b345971e.camel@j-davis.com>
 <CA+TgmoZVCHERUkXhAMT2Er-sKBc5C6_iX+TpxxivBevDHzq2TQ@mail.gmail.com>
 <43bbc9f7318057f51552d5986830908cb018dadf.camel@j-davis.com>
 <1659699.1688086436@sss.pgh.pa.us>
 <20230630050921.GA2640352@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230630050921.GA2640352@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20230630183546.GB2828237%40nathanxps13>
Precedence: bulk

On Thu, Jun 29, 2023 at 10:09:21PM -0700, Nathan Bossart wrote:
> On Thu, Jun 29, 2023 at 08:53:56PM -0400, Tom Lane wrote:
>> I'm leaning to Robert's thought that we need to revert this for now,
>> and think harder about how to make it work cleanly and safely.
> 
> Since it sounds like this is headed towards a revert, here's a patch for
> removing MAINTAIN and pg_maintain.

I will revert this next week unless opinions change before then.  I'm
currently planning to revert on both master and REL_16_STABLE, but another
option would be to keep it on master while we sort out the remaining
issues.  Thoughts?

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com