public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andres Freund <[email protected]>
To: Tom Lane <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Bharath Rupireddy <[email protected]>
Cc: [email protected] <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fdw batch insert error out when set batch_size > 65535
Date: Sat, 1 Jul 2023 23:09:49 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CALj2ACUxf+PRaTVPEY-pV_nNgsB0_U2uU3u8GqMKcF-6M2exjw@mail.gmail.com>
	<[email protected]>
	<CALj2ACXoxbNhpKx2r29OyBdx+fA51Xsv80B-9-xyp1CeBL3ckQ@mail.gmail.com>
	<1! [email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<e! [email protected]>
	<[email protected]>

Hi,

On 2021-06-11 18:44:28 -0400, Tom Lane wrote:
> Tomas Vondra <[email protected]> writes:
> > There's one caveat, though - for regular builds the slowdown is pretty
> > much eliminated. But with valgrind it's still considerably slower. For
> > postgres_fdw the "make check" used to take ~5 minutes for me, now it
> > takes >1h. And yes, this is entirely due to the new test case which is
> > generating / inserting 70k rows. So maybe the test case is not worth it
> > after all, and we should get rid of it.
> 
> I bet the CLOBBER_CACHE animals won't like it much either.
> 
> I suggest what we do is leave it in place for long enough to get
> a round of reports from those slow animals, and then (assuming
> those reports are positive) drop the test.

I just encountered this test because it doesn't succeed on a 32bit system with
address sanitizer enabled - it runs out of memory. At that point there are
"just" 29895 parameters parsed...

It's also the slowest step on skink (valgrind animal), taking nearly an hour.

I think two years later is long enough to have some confidence in this being
fixed?

Greetings,

Andres Freund

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fdw batch insert error out when set batch_size > 65535
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox