Date: Fri, 7 Jul 2023 09:57:10 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>,
	Noah Misch <noah@leadboat.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Fix search_path to a safe value during maintenance
 operations.
Message-ID: <20230707165710.GA3855545@nathanxps13>
References: 
 <CA+TgmoYtJU0KknWr11W--wK=4eJtdHOgupyT=beZVPC8P=o+YA@mail.gmail.com>
 <578fb4be80247570e6a05924908765a0b345971e.camel@j-davis.com>
 <CA+TgmoZVCHERUkXhAMT2Er-sKBc5C6_iX+TpxxivBevDHzq2TQ@mail.gmail.com>
 <43bbc9f7318057f51552d5986830908cb018dadf.camel@j-davis.com>
 <1659699.1688086436@sss.pgh.pa.us>
 <20230630050921.GA2640352@nathanxps13>
 <931c23465c331fc3d53073cdefa53bad464b0469.camel@j-davis.com>
 <20230706172004.GA3635686@nathanxps13>
 <20230707051427.GA3853884@nathanxps13>
 <1130d49de6f6cb09714f702b7b01d0b7b471d370.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1130d49de6f6cb09714f702b7b01d0b7b471d370.camel@j-davis.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230707165710.GA3855545%40nathanxps13>
Precedence: bulk

On Fri, Jul 07, 2023 at 09:22:22AM -0700, Jeff Davis wrote:
> On Thu, 2023-07-06 at 22:14 -0700, Nathan Bossart wrote:
>> Since we are only reverting from v16, the REL_16_STABLE catversion
>> will be
>> bumped ahead of the one on master.
> 
> I don't object to you doing it this way, but FWIW, I'd just revert in
> both branches to avoid this kind of weirdness.
> 
> Also I'm not quite sure how quickly my search_path fix will be
> committed. Hopefully soon, because the current state is not great, but
> it's hard for me to say for sure.

Yeah, I guess I should just revert it in both.  Given your fix will
hopefully be committed soon, I was hoping to avoid reverting and
un-reverting in quick succession to prevent affecting git-blame too much.

I found an example of a post-beta2 revert on both master and a stable
branch where Tom set the catversions to different values (20b6847,
e256312).  I'll do the same here.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com