Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIl3o-0007rP-Pr for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Jul 2023 07:11:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qIl3n-0004d3-Ck for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Jul 2023 07:11:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIl3n-0004ct-3f for pgsql-hackers@lists.postgresql.org; Mon, 10 Jul 2023 07:11:51 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qIl3f-0031nF-Rc for pgsql-hackers@lists.postgresql.org; Mon, 10 Jul 2023 07:11:49 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id AD3B85C008F; Mon, 10 Jul 2023 03:11:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 10 Jul 2023 03:11:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1688973099; x= 1689059499; bh=MJgmLpZVDkSpA8l49syp7mY1ReTkA5nP28vkAz3TEQc=; b=E 5+b8YlX3SHe3VFV2o+FqICBL//aI9SsRmcsOxd86cQjQh5qbLcGylSNg3RRs86mr uZU8YYnwc8ISkCf+cXKq3ZRrtPvT2RdazqYASk3GJfKK+tCZ3QJJKq7D17veShbp MfG78TYhvYNeEzNMUegf/+AdexnLScc05DIq+Pd2z/DuViOpxqXe+6oKY+AYv/ns 4mnSKv93MbmIVHSvzc5KscmiWBU258Ro04OKDu4EUBxz0apRiNQdFvuYzFyk0Pkq BVfgdG97P5ZwaZ+osf9dnBQbewcwHf7Ynid6/0JkrQy5+uKfBnczkqg/nTRxEeRM bbZ793A6o3xysL6hQC+Ug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvdeigdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Jul 2023 03:11:38 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 4B7E39D; Mon, 10 Jul 2023 09:11:36 +0200 (CEST) Date: Mon, 10 Jul 2023 09:11:36 +0200 From: Alvaro Herrera To: Michael Paquier Cc: Andres Freund , "Drouvot, Bertrand" , PostgreSQL Hackers Subject: Re: Autogenerate some wait events code and documentation Message-ID: <20230710071136.jiedze443q7o5vsp@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-Jul-09, Michael Paquier wrote: > Patch 0002 introduces a set of simplifications for the format of > wait_event_names.txt: > - Removal of the first column for the enums. I don't like this bit, because it means the .txt file is now ungreppable as source of the enum name. Things become mysterious and people have to track down the event name by reading the the Perl generating script. It's annoying. I'd rather have the extra column, even if it means a little duplicity. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)