Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIsFD-00052J-Bw for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Jul 2023 14:52:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1qIsFC-00062j-8M for pgsql-hackers@arkaria.postgresql.org; Mon, 10 Jul 2023 14:52:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qIsFB-00062a-VZ for pgsql-hackers@lists.postgresql.org; Mon, 10 Jul 2023 14:52:05 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qIsF9-003ISl-5o for pgsql-hackers@postgresql.org; Mon, 10 Jul 2023 14:52:05 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 4EA50320091B; Mon, 10 Jul 2023 10:52:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 10 Jul 2023 10:52:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1689000720; x= 1689087120; bh=PZ0dUoD+X0+VMSTAfr4c+ct/Aud4awRobP49If7j/kc=; b=i xul9Z9mq9Y3JC31TFxMSepNNa4NihDWv89ydDM4K3ASZKivoxcKJSGrM5uH/pj8t orxN2k5Kx5w2GLm88BbgVTH2uHZjVLj43xYkQyUGkmx9FBiGEa6fYZqKIcNo2jwt CowuC/R4lJI52RbT9xHP8+MvZQMwYpSyTnKmeNJE0Ege4FTFsvaf1ni7KwMUPW1J B3YRdc0fwyhdFViF6fn2FDJfWQAI369a/mST8TqF0peglAvoQHW0U6JN1IFYJkTk Zpvwbm6CJeEdYemuzkltkjJY5dCTEmM4Fvjlzb9QsWt2+TtB/4EzMrQaWuxUb3BD Vh7z5iTRN36dttSJDRDcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvdekgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedvkedtffduffdtffffheffhfejjefhgfeiueeukeejkeff gfdufffhudffffeuveenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 10 Jul 2023 10:52:00 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 83A189D; Mon, 10 Jul 2023 16:51:58 +0200 (CEST) Date: Mon, 10 Jul 2023 16:51:58 +0200 From: Alvaro Herrera To: Amit Langote Cc: PostgreSQL-development Subject: Re: remaining sql/json patches Message-ID: <20230710145158.3eyoqmrbqluulee5@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230710144712.7xih2h5dry3uiydp@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I forgot to add: * 0001 looks an obvious improvement. You could just push it now, to avoid carrying it forward anymore. I would just put the constructName ahead of value expr in the argument list, though. * 0002: I have no idea what this is (though I probably should). I would also push it right away -- if anything, so that we figure out sooner that it was actually needed in the first place. Or maybe you just need the right test cases? -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/