Date: Sat, 15 Jul 2023 14:13:33 -0700
From: Noah Misch <noah@leadboat.com>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Gurjeet Singh <gurjeet@singh.im>, Jeff Davis <pgsql@j-davis.com>,
	pgsql-hackers@postgresql.org,
	Nathan Bossart <nathandbossart@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Fix search_path for all maintenance commands
Message-ID: <20230715211333.GB3675150@rfd.leadboat.com>
References: <e44327179e5c9015c8dda67351c04da552066017.camel@j-davis.com>
 <b701501541a424111ffe47be055e0ccefefd7745.camel@j-davis.com>
 <2cf41c8edeaaf7acb757095e6eceab8ae926f3da.camel@j-davis.com>
 <CABwTF4XWKqx06UxApH8pnBdp_w2iL6VEbGKxDyjCW7-FNhLCBQ@mail.gmail.com>
 <CAKFQuwbcUv9QmrfQKRRi1aq4E68xHD9N05_VZ2TLbMpxMV9Opg@mail.gmail.com>
 <CABwTF4W5mZ+5fJEEh2vp7trGzwn-gnG6o13hAALmLjHdpeUn2g@mail.gmail.com>
 <CAKFQuwZmswfTKtx6oUY0N7UB62cO_nABMgQgdcvrD8r4qjvUJg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAKFQuwZmswfTKtx6oUY0N7UB62cO_nABMgQgdcvrD8r4qjvUJg@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: <https://www.postgresql.org/message-id/20230715211333.GB3675150%40rfd.leadboat.com>
Precedence: bulk

On Thu, Jul 13, 2023 at 02:07:27PM -0700, David G. Johnston wrote:
> On Thu, Jul 13, 2023 at 2:00 PM Gurjeet Singh <gurjeet@singh.im> wrote:
> > On Thu, Jul 13, 2023 at 1:37 PM David G. Johnston <david.g.johnston@gmail.com> wrote:
> > >  I'm against simply breaking the past without any recourse as what we
> > did for pg_dump/pg_restore still bothers me.
> >
> > I'm sure this is tangential, but can you please provide some
> > context/links to the change you're referring to here.
>
> Here is the instigating issue and a discussion thread on the aftermath:
> https://wiki.postgresql.org/wiki/A_Guide_to_CVE-2018-1058%3A_Protect_Your_Search_Path
> https://www.postgresql.org/message-id/flat/13033.1531517020%40sss.pgh.pa.us#2aa2e25816d899d62f168926e3ff17b1

I don't blame you for feeling bothered about it.  A benefit of having done it
is that we gained insight into the level of pain it caused.  If it had been
sufficiently painful, someone would have quickly added an escape hatch.  Five
years later, nobody has added one.

The 2018 security fixes instigated many function repairs that $SUBJECT would
otherwise instigate.  That wasn't too painful.  The net new pain of $SUBJECT
will be less, since the 2018 security fixes prepared the path.  Hence, I
remain +1 for the latest Davis proposal.