Date: Tue, 18 Jul 2023 09:07:13 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Inefficiency in parallel pg_restore with many tables
Message-ID: <20230718160713.GA1139177@nathanxps13>
References: <20230718045701.GA1090171@nathanxps13>
 <20230718160511.loirkf5fwjm5ut73@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230718160511.loirkf5fwjm5ut73@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/20230718160713.GA1139177%40nathanxps13>
Precedence: bulk

On Tue, Jul 18, 2023 at 06:05:11PM +0200, Alvaro Herrera wrote:
> On 2023-Jul-17, Nathan Bossart wrote:
> 
>> @@ -35,7 +42,11 @@ binaryheap_allocate(int capacity, binaryheap_comparator compare, void *arg)
>>  	binaryheap *heap;
>>  
>>  	sz = offsetof(binaryheap, bh_nodes) + sizeof(Datum) * capacity;
>> +#ifdef FRONTEND
>> +	heap = (binaryheap *) pg_malloc(sz);
>> +#else
>>  	heap = (binaryheap *) palloc(sz);
>> +#endif
> 
> Hmm, as I recall fe_memutils.c provides you with palloc() in the
> frontend environment, so you don't actually need this one.

Ah, yes it does.  Thanks for the pointer.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com