Date: Sat, 22 Jul 2023 07:04:38 -0700
From: Noah Misch <noah@leadboat.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	"David G. Johnston" <david.g.johnston@gmail.com>,
	Gurjeet Singh <gurjeet@singh.im>, pgsql-hackers@postgresql.org,
	Robert Haas <robertmhaas@gmail.com>, Greg Stark <stark@mit.edu>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Fix search_path for all maintenance commands
Message-ID: <20230722140438.GA50610@rfd.leadboat.com>
References: <b701501541a424111ffe47be055e0ccefefd7745.camel@j-davis.com>
 <2cf41c8edeaaf7acb757095e6eceab8ae926f3da.camel@j-davis.com>
 <CABwTF4XWKqx06UxApH8pnBdp_w2iL6VEbGKxDyjCW7-FNhLCBQ@mail.gmail.com>
 <CAKFQuwbcUv9QmrfQKRRi1aq4E68xHD9N05_VZ2TLbMpxMV9Opg@mail.gmail.com>
 <CABwTF4W5mZ+5fJEEh2vp7trGzwn-gnG6o13hAALmLjHdpeUn2g@mail.gmail.com>
 <CAKFQuwZmswfTKtx6oUY0N7UB62cO_nABMgQgdcvrD8r4qjvUJg@mail.gmail.com>
 <20230715211333.GB3675150@rfd.leadboat.com>
 <20230717175813.GA717781@nathanxps13>
 <2ad1dd4e5be5567c0d75676b348eab33b529e974.camel@j-davis.com>
 <a5960b98b7d8b655f46b4b69387f1290f5848ad4.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a5960b98b7d8b655f46b4b69387f1290f5848ad4.camel@j-davis.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: <https://www.postgresql.org/message-id/20230722140438.GA50610%40rfd.leadboat.com>
Precedence: bulk

On Fri, Jul 21, 2023 at 03:32:43PM -0700, Jeff Davis wrote:
> Why do we switch to the table owner and use
> SECURITY_RESTRICTED_OPERATION in DefineIndex(), when we will switch in
> index_build (etc.) anyway?

Commit a117ceb added that, and it added some test cases that behaved
differently without that.

> Similarly, why do we switch in vacuum_rel(),
> when it doesn't matter for lazy vacuum and we will switch in
> cluster_rel() and do_analyze_rel() anyway?

It conforms to the "as soon as possible after locking the relation" coding
rule that commit a117ceb wrote into miscinit.c.  That provides future
proofing.