Date: Tue, 25 Jul 2023 17:16:56 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Kirk Wolak <wolakk@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Eric Radman <ericshane@eradman.com>, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Add function to_oct
Message-ID: <20230726001656.GC2992317@nathanxps13>
References: <Y6IyTQQ/TsD5wnsH@vm3.eradman.com>
 <5c260f97-d8c8-4a68-7498-022e550c6b10@enterprisedb.com>
 <CACLU5mQ9BGiMaTbS+EpvxngdEf35aX+Tcs31K8UJMkbxaZh5JA@mail.gmail.com>
 <20230725232426.GA2992317@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230725232426.GA2992317@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20230726001656.GC2992317%40nathanxps13>
Precedence: bulk

On Tue, Jul 25, 2023 at 04:24:26PM -0700, Nathan Bossart wrote:
> I started taking a look at this and ended up adding to_binary() and a
> bigint version of to_oct() for completeness.  While I was at it, I moved
> the base-conversion logic out to a separate static function that
> to_binary/oct/hex all use.

Bleh, this patch seems to fail horribly on 32-bit builds.  I'll look into
it soon.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com