Date: Fri, 28 Jul 2023 10:14:29 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Gurjeet Singh <gurjeet@singh.im>
Cc: pgsql-hackers@postgresql.org, tgl@sss.pgh.pa.us
Subject: Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb
Message-ID: <20230728171429.GA3764457@nathanxps13>
References: <20230628045741.GA1813397@nathanxps13>
 <CABwTF4WB6kYyZzU6Qda_0D7-3SkqzHsVh6q-yscm5FHFQ2F7FQ@mail.gmail.com>
 <20230629052409.GB2049807@nathanxps13>
 <20230719174311.GA1186744@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230719174311.GA1186744@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20230728171429.GA3764457%40nathanxps13>
Precedence: bulk

On Wed, Jul 19, 2023 at 10:43:11AM -0700, Nathan Bossart wrote:
> On Wed, Jun 28, 2023 at 10:24:09PM -0700, Nathan Bossart wrote:
>> The same commit that added this comment (ff402ae) also set the
>> allow_password_reuse parameter to true in vacuumdb's connectDatabase()
>> calls.  I found a message from the corresponding thread that provides some
>> additional detail [0].  I wonder if this comment should instead recommend
>> against using the allow_password_reuse flag unless reconnecting to the same
>> host/port/user target.  Connecting to different databases with the same
>> host/port/user information seems okay.  Maybe I am missing something... 
> 
> I added Tom here since it looks like he was the original author of this
> comment.  Tom, do you have any concerns with updating the comment for
> connectDatabase() in src/fe_utils/connect_utils.c like this?

I went ahead and committed this.  I'm happy to revisit if there are
concerns.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com