Date: Tue, 1 Aug 2023 08:45:54 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: add timing information to pg_upgrade
Message-ID: <20230801154554.GA723589@nathanxps13>
References: <20230727235134.GA3658499@nathanxps13>
 <CALj2ACUT86rjj5Vf5gt-bceUx4C43vcML7zbNW4NyGyo-iN3xw@mail.gmail.com>
 <20230728173814.GA3765390@nathanxps13>
 <20230728184735.GC3661419@nathanxps13>
 <CALj2ACVVvk1cYLtWVxHv=Z1Ubq=UES9fhKbUU4c9k4W+fEDnbw@mail.gmail.com>
 <20230729211418.GA189222@nathanxps13>
 <CALj2ACUEkFmk8x8XTuN=ZgEMtQ6zuZP2jDy4Ri-woaL0i1ABfg@mail.gmail.com>
 <20230731183702.GA537853@nathanxps13>
 <d92952c7-e97d-933e-2558-ebe3708336e8@eisentraut.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d92952c7-e97d-933e-2558-ebe3708336e8@eisentraut.org>
Archived-At: 
 <https://www.postgresql.org/message-id/20230801154554.GA723589%40nathanxps13>
Precedence: bulk

On Tue, Aug 01, 2023 at 09:46:02AM +0200, Peter Eisentraut wrote:
> On 31.07.23 20:37, Nathan Bossart wrote:
>> -	prep_status("Checking for incompatible \"aclitem\" data type in user tables");
>> +	prep_status("Checking for \"aclitem\" data type in user tables");
> 
> Why these changes?  I think this is losing precision about what it's doing.

The message is too long, so there's no space between it and the "ok"
message:

	Checking for incompatible "aclitem" data type in user tablesok

Instead of altering the messages, we could bump MESSAGE_WIDTH from 60 to
62 or 64.  Do you prefer that approach?  (BTW this probably needs to be
back-patched to v16.)

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com