Date: Wed, 2 Aug 2023 09:09:14 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: add timing information to pg_upgrade
Message-ID: <20230802160914.GA1025261@nathanxps13>
References: <20230728173814.GA3765390@nathanxps13>
 <20230728184735.GC3661419@nathanxps13>
 <CALj2ACVVvk1cYLtWVxHv=Z1Ubq=UES9fhKbUU4c9k4W+fEDnbw@mail.gmail.com>
 <20230729211418.GA189222@nathanxps13>
 <CALj2ACUEkFmk8x8XTuN=ZgEMtQ6zuZP2jDy4Ri-woaL0i1ABfg@mail.gmail.com>
 <20230731183702.GA537853@nathanxps13>
 <d92952c7-e97d-933e-2558-ebe3708336e8@eisentraut.org>
 <20230801154554.GA723589@nathanxps13>
 <68c0092c-2d81-68a4-04c5-920bc428feac@eisentraut.org>
 <CALj2ACXNN5_pqiHd7CNmsRfT+0duL=tgNiZCqYwALiWiB=YUew@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CALj2ACXNN5_pqiHd7CNmsRfT+0duL=tgNiZCqYwALiWiB=YUew@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230802160914.GA1025261%40nathanxps13>
Precedence: bulk

On Wed, Aug 02, 2023 at 01:02:53PM +0530, Bharath Rupireddy wrote:
> On Wed, Aug 2, 2023 at 12:45 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>> I think we should change the output format to be more like initdb, like
>>
>>      Doing something ... ok
>>
>> without horizontally aligning all the "ok"s.
> 
> While this looks simple, we might end up with a lot of diff and
> changes after removing MESSAGE_WIDTH. There's a significant part of
> pg_upgrade code that deals with MESSAGE_WIDTH. I don't think it's
> worth the effort. Therefore, I'd prefer the simplest possible fix -
> change the message to '"Checking for  \"aclitem\" data type in user
> tables". It may be an overkill, but we can consider adding
> Assert(sizeof(message) < MESSAGE_WIDTH) in progress report functions
> to not encourage new messages to end up in the same formatting issue.

I don't think it's that difficult.  ІMO the bigger question is whether we
want to back-patch such a change to v16 at this point.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com