Feedback-ID: id4a34324:Fastmail
Date: Wed, 2 Aug 2023 09:25:50 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: SIGQUIT handling, redux
Message-ID: <20230802162550.6d6ya6k2djpoxplb@awork3.anarazel.de>
References: <1850884.1599601164@sss.pgh.pa.us>
 <20200909192620.dylomoxknmt6rdb3@alap3.anarazel.de>
 <110116.1599682140@sss.pgh.pa.us>
 <113530.1599684626@sss.pgh.pa.us>
 <116384.1599688841@sss.pgh.pa.us>
 <141736.1599693895@sss.pgh.pa.us>
 <320251.1599792006@sss.pgh.pa.us>
 <394091.1599839575@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <394091.1599839575@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20230802162550.6d6ya6k2djpoxplb%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2020-09-11 11:52:55 -0400, Tom Lane wrote:
> It's simple enough that maybe we could back-patch it, once it's
> aged awhile in HEAD.  OTOH, given the lack of field reports of
> trouble here, I'm not sure back-patching is worth the risk.

FWIW, looking at collected stack traces in azure, there's a slow but steady
stream of crashes below StartupPacketTimeoutHandler. Most seem to be things
like
libcrypto->malloc->StartupPacketTimeoutHandler->proc_exit->socket_close->free->crash
there's a few other variants, some where the stack apparently was not
decipherable for the relevant tooling.

Note that this wouldn't even include cases where this caused hangs - which is
quite common IME.


Unsurprisingly just in versions before 14, where this change went in.

I think that might be enough evidence for backpatching the commit? I've not
heard of issues due to the checks in check_on_shmem_exit_lists_are_empty().

Greetings,

Andres Freund