Feedback-ID: ia2694551:Fastmail
Date: Thu, 3 Aug 2023 19:59:40 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Dave Cramer <davecramer@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	nathandbossart@gmail.com
Subject: Re: Using defines for protocol characters
Message-ID: <20230803175940.vf3os5y37c7vrbwl@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CADK3HHKbBmK-PKf1bPNFoMC+oBt+pD9PH8h5nvmBQskEHm-Ehw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230803175940.vf3os5y37c7vrbwl%40alvherre.pgsql>
Precedence: bulk

On 2023-Aug-03, Dave Cramer wrote:

> Greetings,
> 
> Attached is a patch which introduces a file protocol.h. Instead of using
> the actual characters everywhere in the code this patch names the
> characters and removes the comments beside each usage.

I saw this one last week.  I think it's a very idea (and I fact I had
thought of doing it when I last messed with libpq code).

I don't really like the name pattern you've chosen though; I think we
need to have a common prefix in the defines.  Maybe prepending PQMSG_ to
each name would be enough.  And maybe turn the _RESPONSE and _REQUEST
suffixes you added into prefixes as well, so instead of PARSE_REQUEST
you could make it PQMSG_REQ_PARSE, PQMSG_RESP_BIND_COMPLETE and so
on.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
<Schwern> It does it in a really, really complicated way
<crab> why does it need to be complicated?
<Schwern> Because it's MakeMaker.