Date: Mon, 07 Aug 2023 14:46:34 +0900 (JST)
Message-Id: <20230807.144634.593425755953926995.horikyota.ntt@gmail.com>
To: bertranddrouvot.pg@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: "duplicated" wait events
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <701f45b5-13a3-6d75-cd24-835cc0716ecb@gmail.com>
References: <701f45b5-13a3-6d75-cd24-835cc0716ecb@gmail.com>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230807.144634.593425755953926995.horikyota.ntt%40gmail.com>
Precedence: bulk

At Fri, 4 Aug 2023 17:07:51 +0200, "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com> wrote in 
> SynRep currently appears in "IPC" and "LWLock" (see [2])
> WALWrite currently appears in "IO" and "LWLock" (see [2])
> 
> I think that can lead to confusion and it would be better to avoid
> duplicate wait event
> name across Wait Class (and so fix those 2 ones above), what do you
> think?

I think it would be handy to be able to summirize wait events by event
names, instead of classes. In other words, grouping wait events
through all classes according to their purpose. From that perspective,
I'm rather fan of consolidating event names (that is, the opposite of
your proposal).

However, it seems the event weren't named with this consideration. So
I'm on the fence about this change.


By the way, I couldn't figure out how to tag event names without
messing up the source tree. This causes meson to refuse a build..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center