Date: Mon, 7 Aug 2023 14:47:14 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Cramer <davecramer@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Peter Smith <smithpb2250@gmail.com>,
	Tatsuo Ishii <ishii@sraoss.co.jp>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
Message-ID: <20230807214714.GA1284531@nathanxps13>
References: 
 <CAHut+PuE-3tc_6m06bwnjftk2KBM728ZSDhuL1_=vRCfEGMZ1A@mail.gmail.com>
 <20230807091044.jjgsl2rgheazaung@alvherre.pgsql>
 <CADK3HH+aXM82oY-tUzidBS1bfqoUFubVxygmFaBFZFV=3iHYdw@mail.gmail.com>
 <CA+TgmoZ=XfKEqiq80SbN0R_XpLnnkgjGuO5WBTL0nYTseKD4TQ@mail.gmail.com>
 <838284.1691432698@sss.pgh.pa.us>
 <CA+TgmoYhA4Df2euFVK24NU9qkcHZBfbJTsr9M=4UWsr+sayD8Q@mail.gmail.com>
 <CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com>
 <859245.1691438528@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <859245.1691438528@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20230807214714.GA1284531%40nathanxps13>
Precedence: bulk

On Mon, Aug 07, 2023 at 04:02:08PM -0400, Tom Lane wrote:
> Dave Cramer <davecramer@gmail.com> writes:
>> On Mon, 7 Aug 2023 at 12:59, Robert Haas <robertmhaas@gmail.com> wrote:
>>> PqMsgEmptyQueryResponse or something like that seems better, if we
>>> want to keep the current capitalization. I'm not a huge fan of the way
>>> we vary our capitalization conventions so much all over the code base,
>>> but I think we would at least do well to keep it consistent from one
>>> end of a certain identifier to the other.
> 
>> I don't have a strong preference, but before I make the changes I'd like to
>> get consensus.
>> Can we vote or whatever it takes to decide on a naming pattern that is
>> acceptable ?
> 
> I'm good with Robert's proposal above.

+1

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com