Date: Tue, 8 Aug 2023 13:06:06 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
	David Steele <david@pgmasters.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
	Michael Brown <michael.brown@discourse.org>,
	pgsql-hackers@postgresql.org
Subject: Re: should frontend tools use syncfs() ?
Message-ID: <20230808200606.GA1384393@nathanxps13>
References: <20210930004340.GM831@telsasoft.com>
 <YVUz0Ay9KshniWBe@paquier.xyz>
 <20220413115412.GM26620@telsasoft.com>
 <20230729214010.GA189456@nathanxps13>
 <20230731175138.GA432880@nathanxps13>
 <20230731183946.GB537853@nathanxps13>
 <20230801163707.GA862840@nathanxps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230801163707.GA862840@nathanxps13>
Archived-At: 
 <https://www.postgresql.org/message-id/20230808200606.GA1384393%40nathanxps13>
Precedence: bulk

I ran a couple of tests for pg_upgrade with 100k tables (created using the
script here [0]) in order to demonstrate the potential benefits of this
patch.

pg_upgrade --sync-method fsync
    real    5m50.072s
    user    0m10.606s
    sys     0m40.298s

pg_upgrade --sync-method syncfs
    real    3m44.096s
    user    0m8.906s
    sys     0m26.398s

pg_upgrade --no-sync
    real    3m27.697s
    user    0m9.056s
    sys     0m26.605s

[0] https://postgr.es/m/3612876.1689443232%40sss.pgh.pa.us

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com