Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qTmPb-00AeOo-Se for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Aug 2023 16:51:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qTmPa-0075Dq-14 for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Aug 2023 16:51:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qTmPZ-0075Di-Oc for pgsql-hackers@lists.postgresql.org; Wed, 09 Aug 2023 16:51:54 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qTmPX-001QoT-EP for pgsql-hackers@lists.postgresql.org; Wed, 09 Aug 2023 16:51:52 +0000 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-565334377d0so48147a12.2 for ; Wed, 09 Aug 2023 09:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691599910; x=1692204710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+kSD5Itk33gsXgWvHu6sAwd0Q58iOkNu1uPSl/dNfTg=; b=ZULJFiv0PJFBdp/pQfAesc+n82gywOKhW+kK7ipg4Y7QX92kcTqF4DLOn9kEBqFPmS lqfoKOQ5KvkN9yq/R/P1Rg0SFGFMbu6sivA/4OV8dWIS7ssJT3vNFBH2XSHnAFdyDEMi gzeup09M/3BJgNYo7vO0VLeHtRlUUeka8EhjjtNaKseDqE9OTYDIx0HVkE+cg8Y1BvVr 3SMT0F5GDhdKgBbw6YxQkZPUrtYJxhFHDC4mGnN8iODsm8Yw/+OWzbDaztcgblKrXTLB I81Ouh1od9Y9UyuZAgoQ9hs7JT2SKpSej9qqLbKC7IGSa/Kn15YPrOvbU111tN1ba8y3 xD4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691599910; x=1692204710; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+kSD5Itk33gsXgWvHu6sAwd0Q58iOkNu1uPSl/dNfTg=; b=jXzmvHE3OWQ378FlFnUnu5II3WlsnufCj5eP9sD+6ggwZZmMZXHnQ3TQ5/a9IKgQ/f NnYXMldOqQ8YFLIatSExDF7C1s0wXu6vNyK0K0Te4D5rYuwOKCxh6JQABTxH8SgEdpd+ oAiTtDmdsu4if8wlzDEnu/CJQdaAvs+mEsKlU0WMWEUk5Y2fKxmGR+uQsfKCJHSBbpM5 JDJp9h9QTTjhYBas0elhd0QtCYhcFsym3PdLRgB2F9qEb/USqjkPg7KHASxCx9YWesVv SlT6VF1y/qn2+1lw//5cLZARHwpPam1hUJjYprJUPnPo1cXaj+6RZk3lkQGGlnGVJ9Nq uR4A== X-Gm-Message-State: AOJu0YwHO14omUzipVfGzF48zoH0DcfWPTMMZqYp/xieFfmiwKn1M3VX KChPhn+jLJJBMJQnZvabRgY= X-Google-Smtp-Source: AGHT+IEs4fnOyI5H9SvZQ5qrdkcsY0hY88uy2fC62Hy8ec69zHID11AHb4CJYK7j8PuzEzreZyvJUQ== X-Received: by 2002:a17:90a:6c23:b0:262:e598:6046 with SMTP id x32-20020a17090a6c2300b00262e5986046mr2996366pjj.28.1691599910113; Wed, 09 Aug 2023 09:51:50 -0700 (PDT) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id pc16-20020a17090b3b9000b00263e1db8460sm1719067pjb.9.2023.08.09.09.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 09:51:49 -0700 (PDT) Date: Wed, 9 Aug 2023 09:51:47 -0700 From: Nathan Bossart To: Dave Cramer Cc: Tom Lane , Peter Eisentraut , Tatsuo Ishii , robertmhaas@gmail.com, alvherre@alvh.no-ip.org, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: Using defines for protocol characters Message-ID: <20230809165147.GA1385791@nathanxps13> References: <859245.1691438528@sss.pgh.pa.us> <20230807214714.GA1284531@nathanxps13> <20230808.074954.718352835768755597.t-ishii@sranhm.sra.co.jp> <110573.1691598848@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Aug 09, 2023 at 10:44:42AM -0600, Dave Cramer wrote: > On Wed, 9 Aug 2023 at 10:34, Tom Lane wrote: >> I agree with Peter: let's use the names in the protocol document >> with a single prefix. I've got mixed feelings about whether that prefix >> should have an underscore, though. > > Well, we're getting closer :) I'm +0.5 for the underscore. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com