Date: Tue, 15 Aug 2023 08:42:08 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Vik Fearing <vik@postgresfriends.org>
Cc: Kirk Wolak <wolakk@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Eric Radman <ericshane@eradman.com>, pgsql-hackers@postgresql.org
Subject: Re: [PATCH] Add function to_oct
Message-ID: <20230815154208.GC2296544@nathanxps13>
References: <Y6IyTQQ/TsD5wnsH@vm3.eradman.com>
 <5c260f97-d8c8-4a68-7498-022e550c6b10@enterprisedb.com>
 <CACLU5mQ9BGiMaTbS+EpvxngdEf35aX+Tcs31K8UJMkbxaZh5JA@mail.gmail.com>
 <20230725232426.GA2992317@nathanxps13>
 <20230726001656.GC2992317@nathanxps13>
 <20230726032917.GA3151386@nathanxps13>
 <20230815041129.GB2294364@nathanxps13>
 <5918e2f0-bb2c-f652-4ec0-982c82fcb0ff@postgresfriends.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5918e2f0-bb2c-f652-4ec0-982c82fcb0ff@postgresfriends.org>
Archived-At: 
 <https://www.postgresql.org/message-id/20230815154208.GC2296544%40nathanxps13>
Precedence: bulk

On Tue, Aug 15, 2023 at 07:58:17AM +0200, Vik Fearing wrote:
> On 8/15/23 06:11, Nathan Bossart wrote:
>> If there are no objections, I'd like to commit this patch soon.
> 
> I just took a look at this (and the rest of the thread).  I am a little bit
> disappointed that we don't have a generic base conversion function, but even
> if we did I think these specialized functions would still be useful.
> 
> No objection from me.

Thanks for taking a look.  I don't mean for this to preclude a generic base
conversion function that would supersede the functions added by this patch.
However, I didn't want to hold up $SUBJECT because of something that may or
may not happen after lots of discussion.  If it does happen within the v17
development cycle, we could probably just remove to_oct/binary.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com