Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVwQt-001eNc-Dt for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Aug 2023 15:58:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qVwQr-00FotU-DD for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Aug 2023 15:58:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qVwQr-00For2-23 for pgsql-hackers@lists.postgresql.org; Tue, 15 Aug 2023 15:58:09 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qVwQo-000Hsz-6K for pgsql-hackers@lists.postgresql.org; Tue, 15 Aug 2023 15:58:07 +0000 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6bd092cba5dso3345777a34.1 for ; Tue, 15 Aug 2023 08:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692115085; x=1692719885; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7YhVxrw4K0SGOzd02ODj9eMw8sFIvGS9472DjCa5oIc=; b=XHz7sdBXK6Ek/Xh/thhGsKayCUJzwPVIGSziV6qryq6vw8z6xJLv97IegdRpHGHJCu 2nupo2L351DWisDxKiTPzriT8AW2zJNHSERkCbbFAduzZD2xFbqeiqTxsrb2g2g6ArTr Ai/ZGxXw9Io6a8T+38b1DcV8bd8G7xnEcmCu5jChXLS5E/PLZWf1mm5GRvkzQrufRnpf 4va0zaWFzrxeExipgva3vwIVo5HEi+usiCxDCk4kAR1YpqTvqszH9ih/jkBMQbxuGys+ sMUw3IGukaspf8/r3/UN4LbTZw3A5U9Q2ihXfDxs4iZNkaxHu11YdFmXRwvxSMg5MRC0 koLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692115085; x=1692719885; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7YhVxrw4K0SGOzd02ODj9eMw8sFIvGS9472DjCa5oIc=; b=S18iRMAnI6VTm9IgTEfd+khYTBwDF5WMSWjGJDesL2rlOgbFSwfdSS8lVa/8hCQNim sRniTRBQ+brfE/k7t3cr+FyF3g7ig3eskF2gypuBzvspqJIhaiJObGdM6HQVe4vr4lEg T2VBO043BivMP0Oc5EhyQfDpLJ0q9s1lE+FGI9JYWxdwsFwjTfL/35TiMsirsMW1HrWm kLTwxXXaq0jJQCMrZ8EuKLJpFJOkI02LPQxf4TKsJ8qOT7PMvXG7PfBKyo33JSUk0Jc0 TU1NU2Xt1c+LJp3p9SNHNhgmDuvLc+JhEK7KNJRVDJVlwTuuQjzElBZaeEOpUABqwNOP Mhpw== X-Gm-Message-State: AOJu0YwFCiT7hgKu/TgPJTVeG5ApIGa4lmt0E5P+aqSTiyKr3PEZejLp e9KywV2SnKFZ4JRJJwfuPok= X-Google-Smtp-Source: AGHT+IHmpAptESV42KD1DcO0B0WlPT4rLnOHO96h1DCNJVnIhppTHqwaipgbcT1X3gJPWaOKXBK4fA== X-Received: by 2002:a9d:4690:0:b0:6bb:3032:55e5 with SMTP id z16-20020a9d4690000000b006bb303255e5mr1649631ote.9.1692115085587; Tue, 15 Aug 2023 08:58:05 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:1461:f5a:50a7:967f]) by smtp.gmail.com with ESMTPSA id h20-20020a9d61d4000000b006bcbffa5167sm5283952otk.76.2023.08.15.08.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 08:58:04 -0700 (PDT) Date: Tue, 15 Aug 2023 08:58:02 -0700 From: Nathan Bossart To: Tatsuo Ishii Cc: alvherre@alvh.no-ip.org, davecramer@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, robertmhaas@gmail.com, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: Using defines for protocol characters Message-ID: <20230815155802.GA2298234@nathanxps13> References: <20230809165147.GA1385791@nathanxps13> <20230809170805.6ugrqutmg7qfmn22@alvherre.pgsql> <20230815040727.GA2294364@nathanxps13> <20230815.144624.47861227022067018.t-ishii@sranhm.sra.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230815.144624.47861227022067018.t-ishii@sranhm.sra.co.jp> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Aug 15, 2023 at 02:46:24PM +0900, Tatsuo Ishii wrote: > Is it possible to put the new define staff into protocol.h then let > pqcomm.h include protocol.h? This makes Pgpool-II and other middle > ware/drivers written in C easier to use the defines so that they only > include protocol.h to use the defines. It is possible, of course, but are there any reasons such programs couldn't include pqcomm.h? It looks relatively inexpensive to me. That being said, I'm fine with the approach you describe if the folks in this thread agree. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com