Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW0iD-001rAG-Gg for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Aug 2023 20:32:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qW0hE-00012e-6g for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Aug 2023 20:31:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qW0hD-00012W-T3 for pgsql-hackers@lists.postgresql.org; Tue, 15 Aug 2023 20:31:20 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qW0h9-000LME-Tv for pgsql-hackers@postgresql.org; Tue, 15 Aug 2023 20:31:19 +0000 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3a81154c570so916677b6e.1 for ; Tue, 15 Aug 2023 13:31:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692131473; x=1692736273; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=G3KHa0Lz5JYwD7gjO1qNtNDFI9YeLy06EivIKrH6ZGU=; b=agHoZVXB+GedzRgjSH6ULuqGYx2Dz6XbxMzzSVPIW6NFUS2kYDohO1g2PHf8h7TIr7 8q9tNavVePzBwI0az65ZFaPe+g5sVdToc2+Dvfrn/GKPSWtO7Gad9fQnxi0cpFfT/y7e TY9ZxKvh/k2pwb8qy37Aki08tQAULinfN7a0R4n3NYtuApZPzszrtcW2O/hZ0uzFBwSV q7V85juYBsaMn4GFv6FCiRQj37lAZDAIqcLgNnXCjEf2MAoFWB8Lk05H/+9wBcB7Gp0Q jWdkV8e8YksDq3rykkC6bkjZ26j2b50pfyKwGzFg4d6oqGH/b8Vx/+49HB9dD3uJwFc9 EtqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692131473; x=1692736273; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=G3KHa0Lz5JYwD7gjO1qNtNDFI9YeLy06EivIKrH6ZGU=; b=C13R/tnUDup+MWg3LTsdLueL4F0oen36IRIq8c4eV5WHokisvnPjetWXCOuJs3bMBt /my6hiXbRbII9lBHHNBdXPN9OPUh9becMUEumYzENWB9D/zZcNLuY/8WGnhIUBIMmdNl CbLXyfo27hTNiKv3ClZQxki+gWpfThmaHDmX+W4XwSEqNlJbuC5zN/vSsQFd7cmZhYdT 6yaWDPhEEB4NSXckJlQgWTHhL1As3vwbw/QfWCayqv0CnohMX4C3xOMPd+Mh6aCk5p30 nmXt9SPcDXan/RvSAICOzFqh/q7VLMD8/QM1jyVOmb0lCnJQ51366bGOlfi7wDfKil72 +8pA== X-Gm-Message-State: AOJu0YzkgOlpQvTKhglMugQeKQB4SJUcNxKv+1PGIVu94HMNW0eZ5UUt j1sqczAql7dk0poODJ9wEEg= X-Google-Smtp-Source: AGHT+IEQc2PDsYe75X6VBRY8oS5MvLP7RZVuH41ENdkIZ3FUCrEOpT94R4jQLpbJxZ2GBQEZKIPx8A== X-Received: by 2002:a05:6808:1788:b0:3a3:e638:78d2 with SMTP id bg8-20020a056808178800b003a3e63878d2mr13812811oib.12.1692131473489; Tue, 15 Aug 2023 13:31:13 -0700 (PDT) Received: from nathanxps13 (162-195-170-173.lightspeed.stlsmo.sbcglobal.net. [162.195.170.173]) by smtp.gmail.com with ESMTPSA id ex5-20020a056808298500b003a7527207b5sm5823298oib.7.2023.08.15.13.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 13:31:12 -0700 (PDT) Date: Tue, 15 Aug 2023 13:31:09 -0700 From: Nathan Bossart To: Peter Geoghegan Cc: Andrew Dunstan , Jelte Fennema , Michael Paquier , "shiy.fnst@fujitsu.com" , Robert Haas , Tom Lane , Justin Pryzby , Andres Freund , Noah Misch , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut Subject: Re: run pgindent on a regular basis / scripted manner Message-ID: <20230815203109.GA2596919@nathanxps13> References: <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="d6Gm4EdcadzBjdND" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --d6Gm4EdcadzBjdND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 11, 2023 at 01:59:40PM -0700, Peter Geoghegan wrote: > I'm starting to have doubts about this policy. There have now been > quite a few follow-up "fixes" to indentation issues that koel > complained about. None of these fixups have been included in > .git-blame-ignore-revs. If things continue like this then "git blame" > is bound to become much less usable over time. Should we add those? Patch attached. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com --d6Gm4EdcadzBjdND Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="v1-0001-Add-a-few-recent-commits-to-.git-blame-ignore-rev.patch" From f4f158e153f9027330ce841ca79b5650dfd24a0e Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Tue, 15 Aug 2023 13:24:18 -0700 Subject: [PATCH v1 1/1] Add a few recent commits to .git-blame-ignore-revs. --- .git-blame-ignore-revs | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 00b548c7b0..2ff86c8d0d 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -14,6 +14,27 @@ # # $ git log --pretty=format:"%H # %cd%n# %s" $PGINDENTGITHASH -1 --date=iso +89be0b89ae60c63856fd26d82a104781540e2312 # 2023-08-15 17:45:00 +0900 +# Fix code indentation vioaltion introduced in commit 9e9931d2b. + +5dc456b7dda4f7d0d7735b066607c190c74d174a # 2023-08-11 20:43:34 +0900 +# Fix code indentation violations introduced by recent commit + +62e9af4c63fbd36fb9af8450fb44bece76d7766f # 2023-07-25 12:35:58 +0530 +# Fix code indentation vioaltion introduced in commit d38ad8e31d. + +4e465aac36ce9a9533c68dbdc83e67579880e628 # 2023-07-18 14:04:31 +0900 +# Fix indentation in twophase.c + +328f492d2565cfbe383f13a69425d751fd79415f # 2023-07-13 22:26:10 +0900 +# Fix code indentation violation in commit b6e1157e7d + +69a674a170058e63e8178aec8a36a673efce8801 # 2023-07-06 11:49:18 +0530 +# Fix code indentation vioaltion introduced in commit cc32ec24fd. + +a4cfeeca5a97f2b5969c31aa69ba775af95ee5a3 # 2023-07-03 12:47:49 +0200 +# Fix code indentation violations + b334612b8aee9f9a34378982d8938b201dfad323 # 2023-06-20 09:50:43 -0400 # Pre-beta2 mechanical code beautification. -- 2.25.1 --d6Gm4EdcadzBjdND--