Feedback-ID: ia2694551:Fastmail
Date: Tue, 15 Aug 2023 23:40:07 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>, nathandbossart@gmail.com,
	davecramer@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org,
	robertmhaas@gmail.com, smithpb2250@gmail.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Using defines for protocol characters
Message-ID: <20230815214007.ptksp5nmtwt3yrjn@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZNvwDsy2lfGXoUUc@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/20230815214007.ptksp5nmtwt3yrjn%40alvherre.pgsql>
Precedence: bulk

On 2023-Aug-16, Michael Paquier wrote:

> On Wed, Aug 16, 2023 at 06:25:09AM +0900, Tatsuo Ishii wrote:
> > Currently pqcomm.h needs c.h which is not problem for Pgpool-II. But
> > what about other middleware?
> 
> Why do you need to include directly c.h?  There are definitions in
> there that are not intended to be exposed.

What this argument says is that these new defines should be in a
separate file, not in pqcomm.h.  IMO that makes sense, precisely because
these defines should be usable by third parties.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/