Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWeBA-003vQI-Sz for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Aug 2023 14:40:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qWeB8-0011zJ-Vs for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Aug 2023 14:40:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWeB8-0011z8-LR for pgsql-hackers@lists.postgresql.org; Thu, 17 Aug 2023 14:40:50 +0000 Received: from mail-oo1-xc31.google.com ([2607:f8b0:4864:20::c31]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qWeB5-000gKR-8T for pgsql-hackers@postgresql.org; Thu, 17 Aug 2023 14:40:50 +0000 Received: by mail-oo1-xc31.google.com with SMTP id 006d021491bc7-56ced49d51aso555573eaf.1 for ; Thu, 17 Aug 2023 07:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692283245; x=1692888045; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dSClGItJOBM5ppI1stM/mChfgixyBMRXotEvrtVd45E=; b=aTUTrjOuT2rN0gQqA6KHqWk5BQMTsYvbAac4PaV0I6dtGYkCHMBL+53HvldkEFzDdO /t0N4fW+tFs8I5vAC0nNQq4+jS9py8+Om0vLpA0/tZmn2YddASg0YoKcNB0gNRq5S7yG WF3xoimeUN717ko4gSc6um4Mczad+3LoBLfypE8Q6J5wMiHRdUaya/JWWqZcWcZpiERM IC0Y/TVI8KtiM16nqcF9aEgH1mC+xJLQka2f9HH6dKsaMsiMuLeOpqDSUcsV8rqGBVUv Yi+9Urwk2O6SoCougUw3sd2kUONfrucGGafLEcWyWviiJXHyFbBTDK3LLGxMKA8548Ol YMtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692283245; x=1692888045; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dSClGItJOBM5ppI1stM/mChfgixyBMRXotEvrtVd45E=; b=HLbA6ZYsS/3ntCm7c46/hwUPkEjP8GDoHzHUPc3UwppnRN2yunzeuqz5vlRsor4j9u VHlZDJ900X+Otu3ZOekA5b58o8K+COQgeRcpMYlA8SCLDAWCBpnw4oIFNeFFmyy/7mpm NrjFMdAjMOKIFwJFf1kpjdkF2YdZQ+AwLEVetXlsd0zJnu/iVre/sRGDDjTCo7rMUumq 7ZjI3HvhfF4SYpXOnqvcQuAUNHRIFrSuz0htMkkj5YaUGnYfv6tgDqmQTjn3h/80Pim1 NgQrTIsEyXb9mBSKl3Cci5cHH/iWazSGaQznLWhwjBtQbhSsGtgMYcc6QXibo7U4oHgA bUWw== X-Gm-Message-State: AOJu0YxKaWSUG1FSuXt9A5YtJBC3jA2c+zy0tvp3whJiYWr5RvWDlQ7O s7bS7jMdClnVI2yE3zDGoZ8= X-Google-Smtp-Source: AGHT+IEVPK/81si7f+hRQ0Nlvvaoa/PEu141L+0WMxSpLSU6nFOi7E4qIaRyqLq9YE27xeFSAfRGxA== X-Received: by 2002:a05:6870:b295:b0:1c4:e708:6cd0 with SMTP id c21-20020a056870b29500b001c4e7086cd0mr1812134oao.19.1692283245191; Thu, 17 Aug 2023 07:40:45 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:3dfe:d9d7:e7f3:524e]) by smtp.gmail.com with ESMTPSA id d15-20020a056871040f00b0019f188355a8sm8666950oag.17.2023.08.17.07.40.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 07:40:44 -0700 (PDT) Date: Thu, 17 Aug 2023 07:40:41 -0700 From: Nathan Bossart To: Peter Geoghegan Cc: Andrew Dunstan , Jelte Fennema , Michael Paquier , "shiy.fnst@fujitsu.com" , Robert Haas , Tom Lane , Justin Pryzby , Andres Freund , Noah Misch , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" , Peter Eisentraut Subject: Re: run pgindent on a regular basis / scripted manner Message-ID: <20230817144041.GA3099457@nathanxps13> References: <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <20230815203109.GA2596919@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Aug 16, 2023 at 01:15:55PM -0700, Peter Geoghegan wrote: > On Tue, Aug 15, 2023 at 1:31 PM Nathan Bossart wrote: >> Should we add those? Patch attached. > > I think that that makes sense. Committed. > I just don't want to normalize updating > .git-blame-ignore-revs very frequently. (Actually, it's more like I > don't want to normalize any scheme that makes updating the ignore list > very frequently start to seem reasonable.) Agreed. I've found myself habitually running pgindent since becoming a committer, but I'm sure I'll forget it one of these days. From a quick skim of this thread, it sounds like a pre-commit hook [0] might be the best option at the moment. [0] https://wiki.postgresql.org/wiki/Working_with_Git#Using_git_hooks -- Nathan Bossart Amazon Web Services: https://aws.amazon.com