Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWgEM-0042QD-AU for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Aug 2023 16:52:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qWgEK-002SJa-Ir for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Aug 2023 16:52:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qWgEK-002SIY-5t for pgsql-hackers@lists.postgresql.org; Thu, 17 Aug 2023 16:52:16 +0000 Received: from mail-oi1-x22b.google.com ([2607:f8b0:4864:20::22b]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qWgED-000exl-75 for pgsql-hackers@lists.postgresql.org; Thu, 17 Aug 2023 16:52:13 +0000 Received: by mail-oi1-x22b.google.com with SMTP id 5614622812f47-3a7d7de894bso5654465b6e.3 for ; Thu, 17 Aug 2023 09:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692291128; x=1692895928; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NWPB8NiBcSQ7uHigMKIJedr07rxp+aaUw8ozfHzC0jo=; b=KrGy0rNlWgdkUCwbeGnIR2NginhKocTE6zMBVEdtw++0ira0CwxPQIyJM2YieGMj5X 7UyTZU8l3mN6YDr46dMBeVyqdchrRtp1cXePUD0ISrR6dU2eJIvTnyfat3UqgrQb2Tri FZ/scx2kJFCWe8mOPNbDhzZITefXwN7fW/Gni0UvzO07I0mjCJJtZ08ioKbEE34cYh4Q L2kGEraHAOpE/LYqqQu96VY0kfRBqrb+PFYO9MSrFsUY8ydtST87zwJSZf9Iy2U3xwAO OoblOOxu+BGZYjn/RWjjWvkEmEEN7rXtNQbvar7SJygY8Xa5viDUEbX8BUTplWifYOEK vpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692291128; x=1692895928; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NWPB8NiBcSQ7uHigMKIJedr07rxp+aaUw8ozfHzC0jo=; b=JS+OSJnhSDtSopx30unlRMZEqKY8fOQ6HY5lrgbKiznf3oskRcHjWtTY8nzq2qm9Hz tLR9s2vv00ciWPN2HZHuPHidpBI+bxKgznxpHTLSHuKMGeOGEN2H/mhpAB8y5jkR/7rd J+Vl9tON8l8R3zFY4nj4MIptLx9R2bcswZNdV8O4xxohW5YYvaiv9G4+F2NYjj0QVtS+ 4EUb585ULCtca/THO1V+ALytdQ4Z/wk1D9BtGGTuxsa3CijtNzX0aiVk4WwaeZd6ZnRw 1t8n2MAbZB0ICxkQ4H+VzYf/IV0I0xOum27AgrDlJ3lAhjDSzKTO+xGx8rskMizsmoqX o6Ew== X-Gm-Message-State: AOJu0Yx4aN5CHuzX3dJRxUvtQy2X/iUP8g8KPT/rdvZa6P2amBTDgASF sF9xOVKo4pfAk4bfIoXTaOI= X-Google-Smtp-Source: AGHT+IEh3tzuDrcGXTxWSFC2qjbfrATb6dsfEKzLCL8U68ZtPX0MZUYnBePziadHNELDT7l+OlDhtA== X-Received: by 2002:aca:230b:0:b0:3a7:5d83:14d2 with SMTP id e11-20020aca230b000000b003a75d8314d2mr127707oie.17.1692291128116; Thu, 17 Aug 2023 09:52:08 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:24f1:2f4c:d0eb:c09]) by smtp.gmail.com with ESMTPSA id ez3-20020a0568082a0300b003a3b321712fsm22924oib.35.2023.08.17.09.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 09:52:07 -0700 (PDT) Date: Thu, 17 Aug 2023 09:52:03 -0700 From: Nathan Bossart To: Robert Haas Cc: Michael Paquier , Alvaro Herrera , Tatsuo Ishii , davecramer@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: Using defines for protocol characters Message-ID: <20230817165203.GA3208351@nathanxps13> References: <20230815214007.ptksp5nmtwt3yrjn@alvherre.pgsql> <20230816192956.GA2908487@nathanxps13> <20230817161334.GA3153559@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Aug 17, 2023 at 12:22:24PM -0400, Robert Haas wrote: > I think this is going to be a major improvement in terms of readability! > > I'm pretty happy with this version, too. We may be running out of > things to argue about -- and no, I don't want to argue about > underscores more! Awesome. If we are indeed out of things to argue about, I'll plan on committing this sometime next week. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com