Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYdXh-002HJn-Dx for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Aug 2023 02:24:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qYdXg-0081qZ-6h for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Aug 2023 02:24:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qYdXf-0081qR-RD for pgsql-hackers@lists.postgresql.org; Wed, 23 Aug 2023 02:24:19 +0000 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qYdXc-000TYP-8X for pgsql-hackers@lists.postgresql.org; Wed, 23 Aug 2023 02:24:19 +0000 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-3a78a29bca3so3553128b6e.0 for ; Tue, 22 Aug 2023 19:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692757454; x=1693362254; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n19Dohabq/ba4B8HyIN/8iGGzmWy1TL6vA7p0j5o6BY=; b=QkmV1dpSs1AadvhDRn8LW7li7Y8DNdzMnTovjW384WyT+m2RmrMS4BfYS/WsNuOwoq WSr5z2Il0AkToHjgoV+1xr0p4bPe3FIzsNeeXfonY3lA4ugKJRXqj07EevxdUzkRl8mG sZZ8wjRE9Ql9rtlTH87q3HZC9A3eOGLLGrJOfbOtWYsMYZJi1JxXHoFNsRLz+KwxfTqW 3WYBmA1aj27ClrCYgiIm5aNYbKeDWViivK13JCtEezcxb1hzgOPi448inrIZa/vmGvDE hC6a2oX7HYOqEHuQlh7Afx6DiaVbJG5ExyPhmam7iCjkKHcGPWUMC0GJJvRFLq72YONj M9Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692757454; x=1693362254; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n19Dohabq/ba4B8HyIN/8iGGzmWy1TL6vA7p0j5o6BY=; b=NGJ9qYQ4QV4itMbmKgyxbb+pqEcNdCf+cyIMGFzSyHkGz5B6hBI3V9pJXaSj+Sm0LQ NCDMxBYcoH3vfnR2/hku248Uy7OjIaeIUruEVeChYwnXVCEvNeHupV2ZtiFYxJ3z1EN3 RXqRRnNAEDIKwrbqI9twkt14blGz1opOS2zkyvCtarv6TfgVMUnOjTwjPwM15AC5O9/0 S93ISt6BBpcRlSH846YLjXZ/t3tGA1ItPFTGyb2JeuUryU0OZBdWfqA6mTzw2qWkFC8u Heh9i97HrpmVHHJkWQYYvqJLEMrrGX8rh6tySIv10R0jweI6s6WRM+cg4OnAWJZXS7JG /LUg== X-Gm-Message-State: AOJu0YwiLCvt4AauQxQ9liAZL2tdhd8qAFyIp2uqtkIkJdMSCu5keDkw SRf/0PpRM2XlxZZzmHMg33c= X-Google-Smtp-Source: AGHT+IG7rPOva+9y2kzgso868qmAnnM9rwn2NdQOvyQoYxSEuGQqiXCEi/lHlVSieY5tHo0U0EFTOg== X-Received: by 2002:aca:2411:0:b0:3a3:47c5:1de3 with SMTP id n17-20020aca2411000000b003a347c51de3mr12550089oic.49.1692757454230; Tue, 22 Aug 2023 19:24:14 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:b99b:ac94:2251:5012]) by smtp.gmail.com with ESMTPSA id u8-20020a056808150800b003a05ba0ccb2sm5489533oiw.39.2023.08.22.19.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 19:24:13 -0700 (PDT) Date: Tue, 22 Aug 2023 19:24:11 -0700 From: Nathan Bossart To: Robert Haas Cc: Michael Paquier , Alvaro Herrera , Tatsuo Ishii , davecramer@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, smithpb2250@gmail.com, pgsql-hackers@lists.postgresql.org Subject: Re: Using defines for protocol characters Message-ID: <20230823022411.GA860009@nathanxps13> References: <20230815214007.ptksp5nmtwt3yrjn@alvherre.pgsql> <20230816192956.GA2908487@nathanxps13> <20230817161334.GA3153559@nathanxps13> <20230817165203.GA3208351@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817165203.GA3208351@nathanxps13> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Aug 17, 2023 at 09:52:03AM -0700, Nathan Bossart wrote: > On Thu, Aug 17, 2023 at 12:22:24PM -0400, Robert Haas wrote: >> I think this is going to be a major improvement in terms of readability! >> >> I'm pretty happy with this version, too. We may be running out of >> things to argue about -- and no, I don't want to argue about >> underscores more! > > Awesome. If we are indeed out of things to argue about, I'll plan on > committing this sometime next week. Committed. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com