Feedback-ID: id4a34324:Fastmail
Date: Wed, 23 Aug 2023 15:56:30 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Thomas Munro <thomas.munro@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Nazir Bilal Yavuz <byavuz81@gmail.com>
Subject: Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot,
 etc?
Message-ID: <20230823225630.npitkolsqh4q2bv2@awork3.anarazel.de>
References: <20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de>
 <20230823065833.vnnfwoi3n2sbw5kf@awork3.anarazel.de>
 <CF26F682-EA8E-485C-A682-E06A7D3D8D37@yesql.se>
 <20230823192239.jxew5s3sjru63lio@awork3.anarazel.de>
 <DCA2CD4A-E99F-4120-AE96-F510D994FE89@yesql.se>
 <3557216.1692824571@sss.pgh.pa.us>
 <20230823214341.stppgfnhrhmb6igf@awork3.anarazel.de>
 <3565659.1692827753@sss.pgh.pa.us>
 <20230823220612.sglm5g5oxblunst3@awork3.anarazel.de>
 <3570610.1692829946@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3570610.1692829946@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20230823225630.npitkolsqh4q2bv2%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-08-23 18:32:26 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > There are other potential uses for libpq in pg_regress though - I'd e.g. like
> > to have a "monitoring" session open, which we could use to detect that the
> > server crashed (by waiting for the FD to be become invalid). Where the
> > connection default issue could matter more?
> 
> Meh.  I don't find that idea compelling enough to justify adding
> restrictions on what test scenarios will work.  It's seldom hard to
> tell from the test output whether the server crashed.

I find it pretty painful to wade through a several-megabyte regression.diffs
to find the cause of a crash. I think we ought to use
restart_after_crash=false, since after a crash there's no hope for the tests
to succeed, but even in that case, we end up with a lot of pointless contents
in regression.diffs. If we instead realized that we shouldn't start further
tests, we'd limit that by a fair bit.

Greetings,

Andres Freund