public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Ian Lawrence Barwick <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: [email protected]
Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
Date: Wed, 23 Aug 2023 19:51:40 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAB8KJ=j-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few@mail.gmail.com>
<[email protected]>
On Wed, Aug 23, 2023 at 07:32:06PM -0700, Nathan Bossart wrote:
> On Thu, Aug 24, 2023 at 10:22:49AM +0900, Ian Lawrence Barwick wrote:
>> Looking at the code, this is happening because
>> "pgstat_fetch_stat_local_beentry()"
>> expects to be passed the backend ID as an integer representing a 1-based index
>> referring to "localBackendStatusTable", but "pg_stat_get_backend_subxact()"
>> is presumably intended to take the actual BackendId , as per other
>> "pg_stat_get_XXX()"
>> functions.
>
> Yes, this was changed in d7e39d7, but 10ea0f9 seems to have missed the
> memo.
BTW I'd argue that this is a bug in v16 that we should try to fix before
GA, so I've added an open item [0]. I assigned it to Robert (CC'd) since
he was the committer, but I'm happy to pick it up.
[0] https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items#Open_Issues
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox