Date: Fri, 25 Aug 2023 08:36:21 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: "Imseih (AWS), Sami" <simseih@amazon.com>
Cc: Ian Lawrence Barwick <barwick@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	"robertmhaas@gmail.com" <robertmhaas@gmail.com>
Subject: Re: pg_stat_get_backend_subxact() and backend IDs?
Message-ID: <20230825153621.GB1593219@nathanxps13>
References: <CAB8KJ=j-ACb3H4L9a_b3ZG3iCYDW5aEu3WsPAzkm2S7JzS1Few@mail.gmail.com>
 <20230824023206.GA1128857@nathanxps13.lan>
 <20230824025140.GB1128857@nathanxps13.lan>
 <20230824161913.GA1394441@nathanxps13.lan>
 <CAB8KJ=iWYvB1odjFRZybsPeUV8HUAiVVjY9RMHSdvWy1t77cLg@mail.gmail.com>
 <520F48E5-CFE9-45AC-AF81-FC4C63C3A5D2@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <520F48E5-CFE9-45AC-AF81-FC4C63C3A5D2@amazon.com>
Archived-At: <https://www.postgresql.org/message-id/20230825153621.GB1593219%40nathanxps13>
Precedence: bulk

On Fri, Aug 25, 2023 at 03:01:40PM +0000, Imseih (AWS), Sami wrote:
> 1/ cast the return of bsearch. This was done previously and is the common
> convention in the code.

Will do.

> 2/ This will probably be a good time to update the docs for pg_stat_get_backend_subxact [1]
> to call out that "subxact_count" will "only increase if a transaction is performing writes". Also to link
> the reader to the subtransactions doc [2].

I'd rather keep this patch focused on fixing the bug, given we are so close
to the v16 release.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com