Date: Tue, 29 Aug 2023 17:56:15 +0900 (JST)
Message-Id: <20230829.175615.682972421946735863.horikyota.ntt@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Standardize spelling of "power of two"
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
 boundary="--Next_Part(Tue_Aug_29_17_56_15_2023_239)--"
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230829.175615.682972421946735863.horikyota.ntt%40gmail.com>
Precedence: bulk

----Next_Part(Tue_Aug_29_17_56_15_2023_239)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hello.

pg_resetwal and initdb has an error message like this:

msgid "argument of --wal-segsize must be a power of 2 between 1 and 1024"

In other parts in the tree, however, we spell it as "power of two". I
think it would make sense to standardize the spelling for
consistency. See the attached.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

----Next_Part(Tue_Aug_29_17_56_15_2023_239)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="standardize_spelling_of_power_of_two.patch"

diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
index c66467eb95..905b979947 100644
--- a/src/bin/initdb/initdb.c
+++ b/src/bin/initdb/initdb.c
@@ -3350,7 +3350,7 @@ main(int argc, char *argv[])
 	check_need_password(authmethodlocal, authmethodhost);
 
 	if (!IsValidWalSegSize(wal_segment_size_mb * 1024 * 1024))
-		pg_fatal("argument of %s must be a power of 2 between 1 and 1024", "--wal-segsize");
+		pg_fatal("argument of %s must be a power of two between 1 and 1024", "--wal-segsize");
 
 	get_restricted_token();
 
diff --git a/src/bin/pg_resetwal/pg_resetwal.c b/src/bin/pg_resetwal/pg_resetwal.c
index 9bebc2a995..25ecdaaa15 100644
--- a/src/bin/pg_resetwal/pg_resetwal.c
+++ b/src/bin/pg_resetwal/pg_resetwal.c
@@ -298,7 +298,7 @@ main(int argc, char *argv[])
 						exit(1);
 					set_wal_segsize = wal_segsize_mb * 1024 * 1024;
 					if (!IsValidWalSegSize(set_wal_segsize))
-						pg_fatal("argument of %s must be a power of 2 between 1 and 1024", "--wal-segsize");
+						pg_fatal("argument of %s must be a power of two between 1 and 1024", "--wal-segsize");
 					break;
 				}
 

----Next_Part(Tue_Aug_29_17_56_15_2023_239)----